test : refactor parallel/test-tls-ca-concat.js #19092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juggernaut451
force-pushed
the
refactorTestTlsCaConcat
branch
from
e012117 to
0c3bbff
Compare
richardlau
approved these changes
Mar 2, 2018
cjihrig
approved these changes
Mar 2, 2018
addaleax
approved these changes
Mar 2, 2018
tniessen
approved these changes
Mar 4, 2018
jasnell
approved these changes
Mar 5, 2018
Implementing common.mustCall and changing the function to arrow function Fixes : nodejs#14544
juggernaut451
force-pushed
the
refactorTestTlsCaConcat
branch
from
0c3bbff to
ee77247
Compare
|
Resolved :) |
tniessen
added
the
author ready
tniessen
pushed a commit
that referenced
this pull request
Mar 24, 2018
PR-URL: #19092 Fixes: #14544 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in ca22c96. |
targos
pushed a commit
that referenced
this pull request
Mar 27, 2018
PR-URL: #19092 Fixes: #14544 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 3, 2018
PR-URL: #19092 Fixes: #14544 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing common.mustCall and changing the function to arrow function
Fixes : #14544
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test