util: move inspect in separate file #22845
Conversation
nodejs-github-bot
added
build
|
Two questions:
|
😍 😻 😍 😻 |
Yes, but please backport it with other pending changes to util.inspect |
Not really. For me
Yes, definitely. New CI after moving it again: https://ci.nodejs.org/job/node-test-pull-request/17227/ |
BridgeAR
added
the
author ready
The inspect function became very big and it's better to handle this in a separate file.
BridgeAR
force-pushed
the
move-inspect
branch
from
61ffd06 to
1e964d7
Compare
|
Rebased due to conflicts. |
|
|
|
Rebuild Windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20919/ ✔️ |
The inspect function became very big and it's better to handle this in a separate file. PR-URL: nodejs#22845 Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in c600a3c |
|
@BridgeAR please backport asap :) |
The inspect function became very big and it's better to handle this in a separate file. PR-URL: nodejs#22845 Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
The inspect function became very big and it's better to handle this in a separate file. Backport-PR-URL: #23226 PR-URL: #22845 Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
The inspect function became very big and it's better to handle this in a separate file. Backport-PR-URL: #23226 PR-URL: #22845 Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
The inspect function became very big and it's better to handle this
in a separate file.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes