Release proposal: v10.12.0 #23313
Merged
Release proposal: v10.12.0 #23313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #22472 Co-authored-by: Denys Otrishko <[email protected]> PR-URL: #22487 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Added tests to check error in dns.lookupService to increase coverage. PR-URL: #22908 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #22643 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
This adds support for RSA, DSA and EC key pair generation with a variety of possible output formats etc. PR-URL: #22660 Fixes: #15116 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: #22660 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: #22933 Refs: #22550 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
The `name`, `message` and `code` attributes of the DOMException interface should be enumerable and configurable. Aligning the definition with the Web allows us to use it when running the Web Platform Tests. Refs: https://heycam.github.io/webidl/#idl-DOMException PR-URL: #22550 Refs: web-platform-tests/wpt@125950d Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: James M Snell <[email protected]>
This fixes an error when compiling with clang-cl on Windows:
```
src/node.cc(2437,5): error: jump from this goto statement to its label is a Microsoft extension [-Werror,-Wmicrosoft-goto]
goto out;
^
src/node.cc(2441,9): note: jump bypasses variable initialization
DWORD pid = args[0].As<Integer>()->Value();
^
```
PR-URL: #22961
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
common.hasSmallICU is used in only one test and is a one-liner. Move into the test where it is used to chip away at the `common` monolith. PR-URL: #22937 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
There is a very small chance (about 0.4%) that OpenSSL will successfully decrypt a key without the correct passphrase and will then fail while parsing its ASN.1 structure. In those rare cases, the error message will be different. PR-URL: #22980 Fixes: #22978 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #22984 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Currently the documentation is not specific how fast-tracking should be applied. This specifies exactly how things should be done to prevent confusion. PR-URL: #22929 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: George Adams <[email protected]>
Replace references to the outdated `update-v8` tool to its replacement in `node-core-utils` PR-URL: #22913 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
This commit adds a --completion-bash option to node which can be sourced to provide bash code completion for node options. Usage: $ node --completion-bash > node_bash_completion $ source node_bash_completion $ node --[tab] PR-URL: #20713 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
Provide a test to cover adding setting `onmessage` to a non-function. This provides previously-missing coverage for an else block in the `onmessage` setter. PR-URL: #22942 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
PR-URL: #22935 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #22956 Reviewed-By: Matteo Collina <[email protected]>
Add links to the class definition for repl.ReplServer in places where it would be helpful. PR-URL: #23005 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #23006 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
common.leakedGlobals() was exposed only to test its logic. The logic can instead be tested by running a fixture file that leaks a global and seeing if `common` causes an AssertionError on exit. This way, the entire functionality of leak detection is tested rather than just the leakedGlobals() function. It also reduces API surface area for the common monolith by one function. PR-URL: #22965 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #22950 Fixes: #22916 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
This commit adds a CheckOptions function that the options classes can optionally implement to check that options specified are correct (dependencies between options are met or options that are mutually exclusive). In the process of doing this the error pointer passed to Parse was changed to be of type vector so that potentially multiple options check failures can be reported. PR-URL: #22943 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
A push stream should have its writable side closed upon receipt, to avoid emitting the 'aborted' event when the readable side is closed. PR-URL: #22878 Fixes: #22851 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
- In release guide - In Travis config Refs: #20109 PR-URL: #22991 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
In short: Some unit tests are using string literals to simply tell you a conclusion what's right/wrong BUT not tell you what actually values are. So it's necessary to print them out in the console. Refs: #22849 PR-URL: #22891 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]>
Providing `No space left on device` is misleading in this case. Replace it with something that describes it more accurately. Refs: https://stackoverflow.com/questions/22475849/node-js-error-enospc/32600959 PR-URL: #21846 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Original commit message:
PPC: use 64KB ASLR hint on PPC
Change-Id: I2e461f3f7b3abc666ed5dcc3294a14d27ef0fe60
Reviewed-on: https://chromium-review.googlesource.com/1194583
Reviewed-by: Michael Lippautz <[email protected]>
Commit-Queue: Junliang Yan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#55655}
Refs: v8/v8@d48bd16
PR-URL: #22909
Reviewed-By: Michaël Zasso <[email protected]>
1) Currently extra properties on an error will be ignored, if thrown. This information will from now on be visible. 2) In case someone threw a non error object it would have resulted in `[object Object]`. Instead, the full object will now be visible. 3) Some cases were not detected properly as error before and "Thrown: " was visible before. That is now fixed. PR-URL: #22436 Refs: #20253 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
The stack was removed later on instead of never being attached in the first place. PR-URL: #22436 Refs: #20253 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Backport-PR-URL: #23039 PR-URL: #22503 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
|
I think @targos can just take care of it before doing the release itself? (Otherwise, yes, force-pushing commits out of release branches is okay, but you’d typically want to check with the releaser anyway.) |
|
I realize I should have been clearer, sorry. I was asking to force push the commit out. Edit: opened #23408 |
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some situations. Refs: #23307 (comment) PR-URL: #23397 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Continued simplification and clarification of language in README.md. PR-URL: #23322 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Use socket.connect() directly. PR-URL: #23289 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Thomas Watson <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
BTW in the future, if there are any issues with a PR I authored or reviewed, feel free to ping me (+ with my slight insomnia, I sometimes even check notifications in the middle of the night). |
The change that added the --verbose flag was supposed to be semver-major but already landed in a 10.x release. Refs: #22450 PR-URL: #23408 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
PR-URL: #23314 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
PR-URL: #23314 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
PR-URL: #23355 Fixes: #23352 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Notable changes:
* assert
* The diff output is now a tiny bit improved by sorting object
properties when inspecting the values that are compared with each
other. #22788
* cli
* The options parser now normalizes `_` to `-` in all multi-word
command-line flags, e.g. `--no_warnings` has the same effect as
`--no-warnings`. #23020
* Added bash completion for the `node` binary. To generate a bash
completion script, run `node --completion-bash`. The output can be
saved to a file which can be sourced to enable completion.
#20713
* crypto
* Added support for PEM-level encryption.
#23151
* Added an API asymmetric key pair generation. The new methods
`crypto.generateKeyPair` and `crypto.generateKeyPairSync` can be
used to generate public and private key pairs. The API supports
RSA, DSA and EC and a variety of key encodings (both PEM and DER).
#22660
* fs
* Added a `recursive` option to `fs.mkdir` and `fs.mkdirSync`. If
this option is set to true, non-existing parent folders will be
automatically created. #21875
* http2
* Added a `'ping'` event to `Http2Session` that is emitted whenever a
non-ack `PING` is received.
#23009
* Added support for the `ORIGIN` frame.
#22956
* Updated nghttp2 to 1.34.0. This adds RFC 8441 extended connect
protocol support to allow use of WebSockets over HTTP/2.
#23284
* module
* Added `module.createRequireFromPath(filename)`. This new method can
be used to create a custom require function that will resolve
modules relative to the filename path.
#19360
* process
* Added a `'multipleResolves'` process event that is emitted whenever
a `Promise` is attempted to be resolved multiple times, e.g. if the
`resolve` and `reject` functions are both called in a `Promise`
executor. #22218
* url
* Added `url.fileURLToPath(url)` and `url.pathToFileURL(path)`. These
methods can be used to correctly convert between file: URLs and
absolute paths. #22506
* util
* Added the `sorted` option to `util.inspect()`. If set to `true`,
all properties of an object and Set and Map entries will be sorted
in the returned string. If set to a function, it is used as a
compare function. #22788
* The `util.instpect.custom` symbol is now defined in the global
symbol registry as `Symbol.for('nodejs.util.inspect.custom')`.
#20857
* Added support for `BigInt` numbers in `util.format()`.
#22097
* V8 API
* A number of V8 C++ APIs have been marked as deprecated since they
have been removed in the upstream repository. Replacement APIs
are added where necessary. #23159
* Windows
* The Windows msi installer now provides an option to automatically
install the tools required to build native modules.
#22645
* Workers
* Debugging support for Workers using the DevTools protocol has been
implemented. #21364
* The public `inspector` module is now enabled in Workers.
#22769
* Added new collaborators:
* digitalinfinity - Hitesh Kanwathirtha
PR-URL: #23313
targos
force-pushed
the
v10.12.0-proposal
branch
from
61f9972 to
4a276cc
Compare
|
This should be ready now. CI: https://ci.nodejs.org/job/node-test-pull-request/17722/ |
|
@nodejs/lts According to @targos, this is likely to be the last 10.x release before 10.x goes LTS. So maybe give it a quick review? |
|
Release job: https://ci-release.nodejs.org/job/iojs+release/3828/ |
targos
added a commit
that referenced
this pull request
Oct 10, 2018
Notable changes:
* assert
* The diff output is now a tiny bit improved by sorting object
properties when inspecting the values that are compared with each
other. #22788
* cli
* The options parser now normalizes `_` to `-` in all multi-word
command-line flags, e.g. `--no_warnings` has the same effect as
`--no-warnings`. #23020
* Added bash completion for the `node` binary. To generate a bash
completion script, run `node --completion-bash`. The output can be
saved to a file which can be sourced to enable completion.
#20713
* crypto
* Added support for PEM-level encryption.
#23151
* Added an API asymmetric key pair generation. The new methods
`crypto.generateKeyPair` and `crypto.generateKeyPairSync` can be
used to generate public and private key pairs. The API supports
RSA, DSA and EC and a variety of key encodings (both PEM and DER).
#22660
* fs
* Added a `recursive` option to `fs.mkdir` and `fs.mkdirSync`. If
this option is set to true, non-existing parent folders will be
automatically created. #21875
* http2
* Added a `'ping'` event to `Http2Session` that is emitted whenever a
non-ack `PING` is received.
#23009
* Added support for the `ORIGIN` frame.
#22956
* Updated nghttp2 to 1.34.0. This adds RFC 8441 extended connect
protocol support to allow use of WebSockets over HTTP/2.
#23284
* module
* Added `module.createRequireFromPath(filename)`. This new method can
be used to create a custom require function that will resolve
modules relative to the filename path.
#19360
* process
* Added a `'multipleResolves'` process event that is emitted whenever
a `Promise` is attempted to be resolved multiple times, e.g. if the
`resolve` and `reject` functions are both called in a `Promise`
executor. #22218
* url
* Added `url.fileURLToPath(url)` and `url.pathToFileURL(path)`. These
methods can be used to correctly convert between file: URLs and
absolute paths. #22506
* util
* Added the `sorted` option to `util.inspect()`. If set to `true`,
all properties of an object and Set and Map entries will be sorted
in the returned string. If set to a function, it is used as a
compare function. #22788
* The `util.instpect.custom` symbol is now defined in the global
symbol registry as `Symbol.for('nodejs.util.inspect.custom')`.
#20857
* Added support for `BigInt` numbers in `util.format()`.
#22097
* V8 API
* A number of V8 C++ APIs have been marked as deprecated since they
have been removed in the upstream repository. Replacement APIs
are added where necessary. #23159
* Windows
* The Windows msi installer now provides an option to automatically
install the tools required to build native modules.
#22645
* Workers
* Debugging support for Workers using the DevTools protocol has been
implemented. #21364
* The public `inspector` module is now enabled in Workers.
#22769
* Added new collaborators:
* digitalinfinity - Hitesh Kanwathirtha
PR-URL: #23313
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 10, 2018
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 10, 2018
|
@richardlau It would be good to have #23398 in LTS, but it is not critical to get into the initial LTS release |
|
@richardlau Just to clarify … I was under the impression that LTS waiting times don’t apply yet for the first release in a release line that’s marked LTS? |
|
@addaleax It's sort of being discussed (that is, what is the first LTS release) over in nodejs/Release#279. |
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Notable changes:
* assert
* The diff output is now a tiny bit improved by sorting object
properties when inspecting the values that are compared with each
other. #22788
* cli
* The options parser now normalizes `_` to `-` in all multi-word
command-line flags, e.g. `--no_warnings` has the same effect as
`--no-warnings`. #23020
* Added bash completion for the `node` binary. To generate a bash
completion script, run `node --completion-bash`. The output can be
saved to a file which can be sourced to enable completion.
#20713
* crypto
* Added support for PEM-level encryption.
#23151
* Added an API asymmetric key pair generation. The new methods
`crypto.generateKeyPair` and `crypto.generateKeyPairSync` can be
used to generate public and private key pairs. The API supports
RSA, DSA and EC and a variety of key encodings (both PEM and DER).
#22660
* fs
* Added a `recursive` option to `fs.mkdir` and `fs.mkdirSync`. If
this option is set to true, non-existing parent folders will be
automatically created. #21875
* http2
* Added a `'ping'` event to `Http2Session` that is emitted whenever a
non-ack `PING` is received.
#23009
* Added support for the `ORIGIN` frame.
#22956
* Updated nghttp2 to 1.34.0. This adds RFC 8441 extended connect
protocol support to allow use of WebSockets over HTTP/2.
#23284
* module
* Added `module.createRequireFromPath(filename)`. This new method can
be used to create a custom require function that will resolve
modules relative to the filename path.
#19360
* process
* Added a `'multipleResolves'` process event that is emitted whenever
a `Promise` is attempted to be resolved multiple times, e.g. if the
`resolve` and `reject` functions are both called in a `Promise`
executor. #22218
* url
* Added `url.fileURLToPath(url)` and `url.pathToFileURL(path)`. These
methods can be used to correctly convert between file: URLs and
absolute paths. #22506
* util
* Added the `sorted` option to `util.inspect()`. If set to `true`,
all properties of an object and Set and Map entries will be sorted
in the returned string. If set to a function, it is used as a
compare function. #22788
* The `util.instpect.custom` symbol is now defined in the global
symbol registry as `Symbol.for('nodejs.util.inspect.custom')`.
#20857
* Added support for `BigInt` numbers in `util.format()`.
#22097
* V8 API
* A number of V8 C++ APIs have been marked as deprecated since they
have been removed in the upstream repository. Replacement APIs
are added where necessary. #23159
* Windows
* The Windows msi installer now provides an option to automatically
install the tools required to build native modules.
#22645
* Workers
* Debugging support for Workers using the DevTools protocol has been
implemented. #21364
* The public `inspector` module is now enabled in Workers.
#22769
* Added new collaborators:
* digitalinfinity - Hitesh Kanwathirtha
PR-URL: #23313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2018-10-10, Version 10.12.0 (Current), @targos
Notable changes
inspecting the values that are compared with each other. #22788
_to-in all multi-word command-lineflags, e.g.
--no_warningshas the same effect as--no-warnings. #23020nodebinary. To generate a bash completionscript, run
node --completion-bash. The output can be saved to a filewhich can be sourced to enable completion. #20713
crypto.generateKeyPairandcrypto.generateKeyPairSynccan be used togenerate public and private key pairs. The API supports RSA, DSA and EC and
a variety of key encodings (both PEM and DER). #22660
recursiveoption tofs.mkdirandfs.mkdirSync. If this optionis set to true, non-existing parent folders will be automatically created. #21875
'ping'event toHttp2Sessionthat is emitted whenever a non-ackPINGis received. #23009ORIGINframe. #22956support to allow use of WebSockets over HTTP/2. #23284
module.createRequireFromPath(filename). This new method can be usedto create a custom require function that will resolve modules relative to
the filename path. #19360
'multipleResolves'process event that is emitted whenever aPromiseis attempted to be resolved multiple times, e.g. if theresolveand
rejectfunctions are both called in aPromiseexecutor. #22218url.fileURLToPath(url)andurl.pathToFileURL(path). These methodscan be used to correctly convert between file: URLs and absolute paths. #22506
sortedoption toutil.inspect(). If set totrue, allproperties of an object and Set and Map entries will be sorted in the
returned string. If set to a function, it is used as a compare function. #22788
util.instpect.customsymbol is now defined in the global symbolregistry as
Symbol.for('nodejs.util.inspect.custom'). #20857BigIntnumbers inutil.format(). #22097removed in the upstream repository. Replacement APIs are added where
necessary. #23159
the tools required to build native modules. #22645
implemented. #21364
inspectormodule is now enabled in Workers. #22769Commits
12ff395e35] - assert: remove internal errorCache property (Rich Trott) #23304efdb32603c] - (SEMVER-MINOR) assert: improve diff output (Ruben Bridgewater) #227889749d48729] - benchmark: increase lint compliance (Rich Trott) #2330590bbab6f71] - benchmark: refactor util benchmarks (Ruben Bridgewater) #225032d7e4e0116] - benchmark,doc,lib,src,test,tools: fix typos (Brandon Smith) #23302e6484c2c11] - build: restore js2c direct dependency on config.gypi (Refael Ackermann) #23355c4aa0331c1] - build: make configure script verbose by default (Michaël Zasso) #23408cf17759113] - build: toggle lint-cpp using verbose (V) variable (Daniel Bevenius) #23217b0dc0ca9a9] - build: make lint-addon-docs quiet (Daniel Bevenius) #232170f236c8d42] - build: add pgo specific variables to common.gypi (Denys Otrishko) #23102de4d688d1f] - build: cleanup in .gitignore (Refael Ackermann) #2318049b0ec4fe7] - build: add loader path to rpath for cctest (Sam Ruby) #231687d21cc2177] - build: reduce chance of unneeded rebuild (Refael Ackermann) #23156aae0eceea0] - build: encapsulate node/inspector gyp scafolding (Refael Ackermann) #23156180099a5ac] - build: enabling pgo at configure (Octavian Soldea) #21596f4cffffc96] - build: add --quiet to lint-cpp (Daniel Bevenius) #23075d572f6001a] - build: remove unnecessary Makefile output (Rich Trott) #23129fb03faa835] - build: move addons message in Makefile (Rich Trott) #23114948dc71664] - build: make config verbose on CI (Refael Ackermann) #22935b69ed9c80c] - build: stop printing execution of lint-md command (Ruben Bridgewater) #229042b8f569388] - build,deps: refactor and fix v8.gyp (Refael Ackermann) #231824db9e36b57] - build,doc: remove outdatedlint-md-build(Michaël Zasso) #22991c29e5ac5be] - (SEMVER-MINOR) cli: normalize\_→-when parsing options (Anna Henningsen) #2302054ca0e159f] - cluster: move handle tracking out of utils (cjihrig) #23131cb0d8239b7] - cluster: use Map to track handles in master (cjihrig) #231250f133eb5a3] - cluster: use Map to track handles in cluster child (cjihrig) #231252dd157fbf3] - cluster: use Map to track indexes (cjihrig) #2312564f840a767] - cluster: use Map to track round robin workers (cjihrig) #2312522f51a6a83] - cluster: use Map to track callbacks (cjihrig) #2312526c36efa2f] - crypto: remove node::crypto::CheckResult (Tobias Nießen) #232255f450f3f92] - crypto: replace goto SSL_CTX_use_certificate_chain (Daniel Bevenius) #23113db8d99dbc2] - crypto: add virtual dtor to KeyPairGenerationConfig (Daniel Bevenius) #23215f98d441461] - crypto: extract throwInvalidArgType function (Daniel Bevenius) #229471a21cf13cb] - crypto: make PEM parsing RFC7468-compliant (Tobias Nießen) #231649c96573124] - (SEMVER-MINOR) crypto: add support for PEM-level encryption (Tobias Nießen) #23151398c0e03e4] - crypto: replace gotos (Tobias Nießen) #23132a51d839a31] - crypto: remove unnecessary calls to TLS_method() (Daniel Bevenius) #23077074b7af7ef] - crypto: enable auto cert chaining for BoringSSL (Jeremy Apthorp) #221102888f809e3] - crypto: deduplicate cipher initialization code (Tobias Nießen) #230110bc4529a07] - crypto: remove unnecessary usage of goto (Tobias Nießen) #23018cc8219433c] - (SEMVER-MINOR) crypto: allow promisifying generateKeyPair (Tobias Nießen) #22660421909394c] - (SEMVER-MINOR) crypto: add API for key pair generation (Tobias Nießen) #2266076cb52ca11] - deps: upgrade to libuv 1.23.2 (cjihrig) #2333695bdf37265] - (SEMVER-MINOR) deps: update nghttp2 to 1.34.0 (James M Snell) #2328446c7d0d21f] - (SEMVER-MINOR) deps: increase V8 deprecation levels (Anna Henningsen) #23159e3550f2366] - deps: backport 958b761 from upstream V8 (Matheus Marchini) #22914f08373f18d] - deps: cherry-pick 64-bit hash seed commits from V8 (Yang Guo) #23260e93c94c327] - deps: add no-strict-aliasing to ICU cflags (Daniel Bevenius) #231125d70652d86] - deps: fix Array.prototype.forEach on v8 6.8 (Mike Stanton) #22899e668815a24] - deps: cherry-pick dbfcc48 from upstream V8 (Alexey Kozyatinskiy) #22251e5efdba75c] - deps: upgrade to libuv 1.23.1 (cjihrig) #2299739d7699a87] - deps: cherry-pick d48bd16 from upstream V8 (Junliang Yan) #2290962a2c81214] - doc: simplify and clarify README language (Rich Trott) #233227c0d6ac0bd] - doc: simplify governance info in README intro (Rich Trott) #233205ff43006d1] - doc: add link to ABI guide (Gabriel Schulhof)9dd47bcf99] - doc: fix minor typo in streams.md (Rich Trott) #23306a0e8e7fea6] - doc: standardize versions in stream module doc (Rich Trott) #23306eee71d6d16] - doc: add util.inspect() legacy signature (siddhant) #23216fbbb25b901] - doc: edit building-node text (Rich Trott) #23335037063c6ee] - doc: remove 72-hour mentions in pull-requests.md (Rich Trott) #233094c54f897f8] - doc: fix minor typo in n-api.md (Aleksey Chemakin) #23310f1cb8ab4bf] - doc: remove ABI guide (Gabriel Schulhof) #2330339e3ef7739] - doc: Replace vague 'may not' with definitive 'will not' (Mike MacCana) #2314311c674549b] - doc: update author-ready label terms (Vse Mozhet Byt) #2324933e3eb44f7] - doc: update onboarding task (Rich Trott) #23300df4ade7dc7] - doc: use backticks around file names in README.md (Rich Trott) #2329980964d36b7] - doc: improve API Documentation text in README (Rich Trott) #23268ef0f7e613a] - doc: shorten pull request wait time to 48 hours (Rich Trott) #230825b76313059] - doc: improve instructions for verifying binaries (Rich Trott) #232486943fa9fc7] - doc: shorten intro of README.md (Rich Trott) #23073e5bfab0fb6] - doc: add guide about abi stability (Gabriel Schulhof) #23229e283206047] - doc: improvestream.Writablector encoding option docs (Anna Henningsen) #23246bd59d4efbf] - doc: fix code snippets in tls.md (Ouyang Yadong) #2323927c5e96ffe] - doc: leave pull requests open for 72 hours (Rich Trott) #222755836b9fcc8] - doc: specify cluster worker.kill() caveat (cjihrig) #23165ed01b38295] - doc: use stronger language about security of vm (Gus Caplan) #23198eb8721977f] - doc: improve Download section of README (Rich Trott) #23212003d85d2d9] - doc: remove GA tracking (Ben Noordhuis) #230836912376562] - doc: move gibfahn to TSC Emeritus (Gibson Fahnestock) #232381553e21007] - doc: clarify assigning issues to the TSC (Franziska Hinkelmann) #2275971901d6b30] - doc: improve Release Types text in README (Rich Trott) #231908191bee313] - doc: simplify support section of README (Rich Trott) #23170548934d412] - doc: fix incorrect anchoring (#vcbuild.bat -> #vcbuildbat) (Justin Lee) #23211ce006eb68d] - doc: fix minor typo (to early -> too early) (Justin Lee) #2321121490c2a87] - doc: remove recommendation to use node-eps (Richard Lau) #23148e71a72fbf2] - doc: add contents table to CONTRIBUTING.md (ZYSzys) #23140818db4036b] - doc: move perf tools and APIs to Tier 3 (Matheus Marchini) #22915e791abe5ef] - doc: formalizeautousage in C++ style guide (Anna Henningsen) #23028310109691b] - doc: fix casing in stream.md (Sintendo) #23166bb5c6892ee] - doc: add table of contents in BUILDING.md (ZYSzys) #23147cbcf5f88cd] - doc: deeper link to downloads site (Refael Ackermann) #230849109187948] - doc: update guide for assert team (Rich Trott) #230852731d08c33] - doc: add links for fs.createWriteStream() (Rich Trott) #231049fa3813845] - doc: edit fast-tracking section (cjihrig) #2305914327aea7b] - doc: improve instruction to purple merge (Refael Ackermann) #2300787565c763a] - doc: require two approvals to land changes (Rich Trott) #22255e7be1edc49] - doc: fix optional parameters in n-api.md (Lars-Magnus Skog) #2299824073cef6b] - doc: add callback parameters of worker.terminate() (Denis Fäcke) #230026b2e2ff036] - doc: improve metadata for http.request (Tobias Nießen) #2294991b410259e] - doc: add missing metadata for recursive mkdir (Tobias Nießen) #2294915c7c57a78] - doc: add missing metadata for dns.lookup (Tobias Nießen) #2294905196893b9] - doc: fix heading levels in C++ style guide (Anna Henningsen) #2306129a9e8498a] - doc: remove outdated notes on stdio in workers (Anna Henningsen) #23054d3bc862d88] - doc: match program and console output in synopsis.md (Mohammed Essehemy) #2300615b91b9eb8] - doc: add links for repl.ReplServer (Rich Trott) #23005b0e86ea8d0] - doc: update maintaining V8 guide (Michaël Zasso) #2291300dd9738ee] - doc: specify fast-tracking (Ruben Bridgewater) #22929ef5d90dfdc] - doc: add digitalinfinity to collaborators (Hitesh Kanwathirtha) #22984b48dc0b667] - doc,test: fix inspect's sorted compare function (Michaël Zasso) #22992d9d9d23191] - errors: fix ERR_SOCKET_BAD_PORT message (Giovanny Andres Gongora Granada (Gioyik)) #23015bb6530b31b] - fs: consistently return symlink type from readdir (Klaus Meinhardt) #228087e45daf494] - (SEMVER-MINOR) fs: implement mkdir recursive (mkdirp) (Benjamin Coe) #21875c29734c9d6] - fs: improve fs.watch ENOSPC error message (Anna Henningsen) #218467b327ea909] - (SEMVER-MINOR) http2: add RFC 8441 extended connect protocol support (James M Snell) #23284001881f33e] - http2: set nghttp2_option_set_no_closed_streams (David Halls) #231348fe62f8d38] - http2: don't send trailers on a closed connection (André Cruz) #23146d1826fed41] - http2: close fd in doSendFileFD() (cjihrig) #230478bf004b96d] - (SEMVER-MINOR) http2: add ping event (James M Snell) #23009badc38f305] - http2: do not falsely emit 'aborted' on push (Anatoli Papirovski) #2287824675a4306] - (SEMVER-MINOR) http2: add origin frame support (James M Snell) #2295689fe9edd08] - http2: check if stream is not destroyed before sending trailers (Matteo Collina) #22896aa48192f9d] - inspector: add virtual destructor to WorkerDelegate (Daniel Bevenius) #2321516f7f52b24] - inspector: workers debugging (Eugene Ostroukhov) #21364f66e9abcb3] - inspector: implemented V8InspectorClient::resourceNameToUrl (Alexey Kozyatinskiy) #222511c3a2ebfcf] - inspector: enable Inspector JS API in workers (Eugene Ostroukhov) #22769c40e2dd6c9] - lib: reword help text for clarity (Gireesh Punathil) #23016f38eff29e7] - lib: change abstract equal to strict equal (ZYSzys) #229740140a98e05] - lib: make DOMException attributes configurable and enumerable (Joyee Cheung) #225505e7b1082d9] - lib: set Symbol.toStringTag of DOMException (Joyee Cheung) #22933a7f4d5e134] - lib: refactor variable declarations (ZYSzys) #22643fb68ef2e74] - lib: added common.restoreStderr(); to end of file (Mark Abel) #22487600c225439] - (SEMVER-MINOR) module: add createRequireFunction method (Gus Caplan) #19360a65bb42551] - net: use connect() instead of connect.call() (Jackson Tian) #232895a306748e9] - process: allow reading from stdout/stderr sockets (Anna Henningsen) #2305366484b82c4] - (SEMVER-MINOR) process: addmultipleResolvesevent (Ruben Bridgewater) #22218e16dd6d165] - repl: refactor ERR_SCRIPT_EXECUTION_INTERRUPTED stack handling (Ruben Bridgewater) #22436b1ffda6c17] - repl: improve error output (Ruben Bridgewater) #22436cd69e1b6c3] - src: fix ToObject() usage in node_http_parser.cc (cjihrig) #233145228ec4410] - src: fix ToObject() usage in exceptions.cc (cjihrig) #233144d761d4224] - src: reduce variable scope in stream_base.cc (cjihrig) #23297740741b279] - src: reduce variable scope in node_worker.cc (cjihrig) #2329756c2f5702f] - src: reduce variable scope in node_trace_writer.cc (cjihrig) #23297046fd987e4] - src: reduce variable scope in node_url.cc (cjihrig) #2329736c430796b] - src: remove unneeded variables in node_crypto.cc (cjihrig) #23297902ba0ecb4] - src: reduce variable scope in module_wrap.cc (cjihrig) #23297402867c0a9] - src: reduce variable scope in cares_wrap.cc (cjihrig) #23297315bf257e5] - src: fix ToObject() usage in node_crypto.cc (cjihrig) #23298950ccee386] - src: name EmbededderGraph edges and use class names for nodes (Joyee Cheung) #23072390fc85ff0] - src: implement the new EmbedderGraph::AddEdge() (Joyee Cheung) #221065a8396796d] - src: use JS inheritance forAsyncWrap(Anna Henningsen) #23094894210ec12] - src: add virtual desctructor to Options class (Daniel Bevenius) #232158f5fb6f90c] - src: clean up zlib write code (Anna Henningsen) #231832da6f622dc] - (SEMVER-MINOR) src: deprecateUVException()withoutIsolate\*(Anna Henningsen) #23175e9a0cffbd6] - (SEMVER-MINOR) src: deprecate V8 date conversion helpers (Anna Henningsen) #23179a2c1ce24b5] - src: fix indentation forAsyncResource(Anna Henningsen) #2317764689edf76] - src: remove unused using declarations (Daniel Bevenius) #231200202c6c808] - src: remove unused locale.h (Daniel Bevenius) #2312020a4f14c57] - src: make req_wrap a unique_ptr in AfterConnect (Daniel Bevenius) #23115ce7fad5b79] - src: use unique_ptr for obj in SetWeak lambda (Daniel Bevenius) #231177d7dc16240] - src: unique_ptrs in few lambdas (Gireesh Punathil) #231244bd3b6e332] - src: refactor crypto code with RAII cleanup (Gireesh Punathil) #23014f3d09b6e4f] - src: simplifyMessagePortconstruction code a bit (Anna Henningsen) #230364d61c34b9e] - src: fix a typo in the comment (Gireesh Punathil) #23078fa833828b2] - src: added URL::FromFilePath method (Alexey Kozyatinskiy) #22251109aa63910] - src: cache and resue isolate and contex pointers (Gireesh Punathil) #230242f659a3d74] - src: use RAII cleanup in node_i18n.cc (Anna Henningsen) #2302190f1200be9] - src: define zlib constants in node_zlib.cc (Anna Henningsen) #23019d72867ec0c] - src: makeZCtx::Init()non-static (Anna Henningsen) #2301956b1a3cf6e] - src: refactor zlib dictionary to STL vector (Anna Henningsen) #2301976453f1878] - src: replace deprecated uses of FunctionTemplate::GetFunction (Andreas Haas) #22993cb3062aa42] - src: remove calls to SetWrapperClassId() (Joyee Cheung) #22975ab032e4ff4] - src: refactor win32DebugProcess()to use RAII cleanup (Anna Henningsen) #22981b6cd18517c] - src: add CheckOptions to Options classes (Daniel Bevenius) #22943ace6e07f0e] - src: initialize pid variable before goto (Jeremy Apthorp) #2296125bf1f5e28] - stream: improve buffer list inspection (Ruben Bridgewater) #231092b77b94c05] - streams: refactor ReadableStream asyncIterator creation and a few fixes (Gus Caplan) #23042df54db667c] - test: remove internal errorCache property (Rich Trott) #2330470abcf2d10] - test: remove eslint-disable from fixtures (Rich Trott) #23345b2d3445644] - test: read() on dir on AIX does not return EISDIR (Ben Noordhuis) #23330b523f13fa2] - test: add module require tests for certain package.json errors (Tom White) #2328545e0080cf1] - test: remove flaky designation for test (Rich Trott) #22856085de6fe18] - test: swap arguments in strictEqual() (Duarte David) #23204a070842e97] - test: remove obsolete domain test (Julien Gilli)cb68188805] - test: add stdin writable regression test (Anna Henningsen) #2305306b5ef3868] - test: terminate cluster worker in infinite loop (cjihrig) #231659352d9d596] - test: harden test-gc-http-client-timeout (Denys Otrishko) #23184748d9d22fa] - test: add process.stdin.end() TTY regression test (Matteo Collina) #2305144db98a7b6] - test: add more descriptive err message to assert (Josh Broomfield) #23118b2a1cf3793] - test: mark some flakes (Refael Ackermann) #232089b30a635e0] - test: improve test-gc-http-client (Rich Trott) #2314523525b0547] - test: replace localhost with os.hostname in fs-readfilesync (Denys Otrishko) #23101bebd7b2cdc] - test: fix flaky test-gc-net-timeout (Rich Trott) #23139efeb49d224] - test: increase test coverage for fs.promises read (Jennifer Bland) #2280039c2a3f1c1] - test: improve test-gc-http-client-connaborted (Rich Trott) #2309148c1c428f9] - test: improve debugging information for http2 test (Rich Trott) #23058f486186e25] - test: remove setImmediate from timeout test (Rich Trott) #2305885c4ecb8a5] - test: test undefined in util (ZYSzys) #227413e4af49157] - test: add dns.onlookupall() to increase coverage (Masashi Hirano) #22985d68dfa9243] - test: console.table whennullin data (ZYSzys) #229744cda83dae2] - test: improve test-gc-http-client-onerror (Rich Trott) #2309052c6ee789b] - test: improve test-gc-http-client-timeout (Rich Trott) #2308869d3c08be1] - test: improve reliability of test-gc-http-client (Rich Trott) #23087a566f0f43e] - test: improve reliability of test-gc-net-timeout (Rich Trott) #23086c54e42362c] - test: remove unnecessary assertions (Anna Henningsen) #23040adaf530cdb] - test: check parameter type of fs.mkdir() (Masashi Hirano) #22616a3b3485b34] - test: add comment describing test-fs-mkdir (Jennifer Bland) #224245d4bec3e0f] - test: fix flaky sequential/test-fs-watch-system-limit (Anna Henningsen) #230389de6b26a0c] - test: remove string literals for strictEquals/notStrictEquals (MaleDong) #2289143e3cf93e8] - test: do not export common.leakedGlobals() (Rich Trott) #2296570ccec2d91] - test: increase coverage for worker_threads (Rich Trott) #2294283278b23a7] - test: fix flaky key pair generation test (Tobias Nießen) #22980d38ce82756] - test: remove common.hasSmallICU (Rich Trott) #22937dcce2d67ae] - test: add tests to check error in dns.lookupService. (Masashi Hirano) #22908079760f28b] - test: mark some tests as flaky (João Reis) #229414436a3d660] - timers: use custom inspection for linked lists (Ruben Bridgewater) #231084b976df9e2] - tls: fix DEP0083 after upgrading to OpenSSL 1.1.0 (Tobias Nießen) #22953acc4a761b7] - tools: make Travis commit linting more robust (Rich Trott) #23397e2a6e051b3] - tools: apply linting to first commit in PRs (Rich Trott) #2245242e67a4e68] - tools: remove useless assignment from configure.py (Gus Caplan) #232001010ef5df7] - tools: fix ICU shrinker and docs (Steven R. Loomis) #23266d7031df415] - tools: allow input for TTY tests (Anna Henningsen) #230531a92335543] - tools: unify .editorconfig rules for 2-space (Roman Reiss) #23163ef00e5c967] - tools: fix cpplint --quiet option (Daniel Bevenius) #230751cbc2ee034] - tools: update ESLint to 5.6.1 (cjihrig) #23149f6fc7e7aa5] - tools: .eslintrc.js messages "default" typo style (Lovingly) #22868a22485d8f1] - (SEMVER-MINOR) tools: add bash completion for node (Daniel Bevenius) #20713a6562685c3] - Revert "tools,gyp: don't force build actions with multiple outputs" (Sakthipriyan Vairamani (thefourtheye)) #2325773917387f4] - tools,gyp: cosmetic change to GYPmakegenerator outputs (Refael Ackermann) #23156d8cedf545e] - tools,gyp: don't force build actions with multiple outputs (Refael Ackermann) #23156bf17708aa2] - tty: documentWriteStream.cursorTo()and others (Umang Raghuvanshi) #228939c36827e94] - (SEMVER-MINOR) tty: makereadStream.setRawMode()returnthis(Alexander Mills) #2295036028caf8c] - tty: handle setRawMode errors (Nikolai Vavilov) #22886d22ee2c698] - url: use foreach-style C++ loop (Tobias Nießen) #23138f1b1b73c2b] - (SEMVER-MINOR) url: provide pathToFileURL and fileURLToPath (guybedford) #22506384221e75c] - (SEMVER-MINOR) util: support BigInt in util.format (Masashi Hirano) #2209777de1beaf0] - util: move inspect in separate file (Ruben Bridgewater) #22845f2dfebb7b4] - util: update definition of DISALLOW_COPY_AND_ASSIGN macro (Nitish Sakhawalkar) #2309268eaa8789a] - (SEMVER-MINOR) util: add order option to.inspect()(Ruben Bridgewater) #22788a2a1ebfecf] - (SEMVER-MINOR) util: use a shared symbol for util.inspect.custom (chocolateboy) #20857077e7e0ce7] - util: fix indentationLvl when exceeding max call stack size (Ruben Bridgewater) #227875a13e66088] - util: improve inspect performance (Ruben Bridgewater) #2250392e0f38a65] - util: remove outdated TODO (Ruben Bridgewater) #225033b895d1258] - win,msi: display license notes before installing tools (João Reis) #23044cf284c80a9] - win,msi: install Boxstarter from elevated shell (João Reis) #229882b7e18dec5] - win,msi: highlight installation of 3rd-party tools (Tobias Nießen) #23003ebf36cd180] - (SEMVER-MINOR) win,msi: install tools for native modules (João Reis) #22645c34db7a9c2] - worker: reduceMessagePortprototype to documented API (Anna Henningsen) #230372e30a6897d] - worker: hide MessagePort init function behind symbol (Anna Henningsen) #23037b5889d0b84] - worker: only stop inspector if started (Anna Henningsen) #229277639390032] - worker,coverage: support V8 coverage generation (Anna Henningsen) #2292818cbde5ade] - zlib: simplify flushing mechanism (Anna Henningsen) #23186e749a28c55] - zlib: use common owner symbol to access JS wrapper (Anna Henningsen) #23189a6b55c73b0] - zlib: move, rename, document internal params() cb (Anna Henningsen) #23187