build: stop printing execution of lint-md command #22904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The executed command is very verbose and removing that from the output improves the overall experience.
nodejs-github-bot
added
the
build
richardlau
approved these changes
Sep 17, 2018
|
For reference, here's what the output looks like: beforeafterThe difference is more noticeable with word wrapping. |
Trott
approved these changes
Sep 18, 2018
thefourtheye
approved these changes
Sep 18, 2018
BridgeAR
added
fast-track
|
Please +1 if you are fine with fast tracking this. |
|
CI https://ci.nodejs.org/job/node-test-pull-request/17272/ |
lundibundi
approved these changes
Sep 18, 2018
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Sep 19, 2018
The executed command is very verbose and removing that from the output improves the overall experience. PR-URL: nodejs#22904 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
|
Landed in 92fd4fc 🎉 |
targos
pushed a commit
that referenced
this pull request
Sep 20, 2018
The executed command is very verbose and removing that from the output improves the overall experience. PR-URL: #22904 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The executed command is very verbose and removing that from the
output improves the overall experience.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes