worker,coverage: support V8 coverage generation #22928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
added
blocked
nodejs-github-bot
added
c++
addaleax
removed
c++
cjihrig
approved these changes
Sep 18, 2018
BridgeAR
approved these changes
Sep 18, 2018
lpinca
approved these changes
Sep 18, 2018
addaleax
force-pushed
the
worker-coverage
branch
from
20a8c77 to
e8ad93b
Compare
addaleax
added
the
author ready
|
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17322/ (:heavy_check_mark:) |
jasnell
approved these changes
Sep 19, 2018
|
Landed in 0dbc8c8 |
addaleax
added a commit
that referenced
this pull request
Sep 21, 2018
PR-URL: #22928 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
bcoe
reviewed
Sep 21, 2018
| @@ -79,6 +79,23 @@ function nextdir() { | |||
| assert.strictEqual(fixtureCoverage.functions[2].ranges[1].count, 0); | |||
| } | |||
|
|
|||
| // outputs coverage from worker. | |||
| { | |||
There was a problem hiding this comment.
🎉 thanks for seeing this through @addaleax
targos
pushed a commit
that referenced
this pull request
Sep 25, 2018
PR-URL: #22928 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently blocked on #22927. (The first commit in this PR is included from there.)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes