Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark some tests as flaky #22941

Merged
merged 1 commit into from
Sep 19, 2018
Merged

test: mark some tests as flaky #22941

merged 1 commit into from
Sep 19, 2018

Conversation

joaocgreis
Copy link
Member

Marks as flaky 4 tests that have recently failed in CI and don't have PRs open to fix.

Please approve for fast-tracking, feel free to land when the necessary conditions are met.

Refs: #20750
Refs: #22327
Refs: #22762
Refs: nodejs/reliability#16

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@joaocgreis joaocgreis added test Issues and PRs related to the tests. fast-track PRs that do not need to wait for 48 hours to land. labels Sep 19, 2018
@nodejs-github-bot
Copy link
Collaborator

@joaocgreis build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/938/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 19, 2018
@joaocgreis
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17308/

@thefourtheye
Copy link
Contributor

cc @nodejs/testing

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 19, 2018
@joaocgreis @refack
test: mark some tests as flaky
311e72f 
Refs: nodejs#20750
Refs: nodejs#22327
Refs: nodejs#22762
Refs: nodejs/reliability#16

PR-URL: nodejs#22941
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@refack refack force-pushed the joaocgreis-I9J-flaky-tests branch from f0edd8c to 311e72f Compare September 19, 2018 13:05
@refack
Copy link
Contributor

refack commented Sep 19, 2018

Landed in 311e72f
(3 upvoted for fast-tracking)

@refack refack merged commit 311e72f into nodejs:master Sep 19, 2018
@refack refack mentioned this pull request Sep 19, 2018
Closed
targos pushed a commit that referenced this pull request Sep 20, 2018
@joaocgreis @targos
test: mark some tests as flaky
079760f 
Refs: #20750
Refs: #22327
Refs: #22762
Refs: nodejs/reliability#16

PR-URL: #22941
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@joaocgreis @nodejs-github-bot @thefourtheye @refack @jasnell @addaleax @cjihrig @BridgeAR