Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: refactor win32 DebugProcess() to use RAII cleanup #22981

Closed
wants to merge 1 commit into from
Closed

src: refactor win32 DebugProcess() to use RAII cleanup #22981

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Sep 20, 2018 •
edited
Loading

Prefer more idiomatic C++ cleanup code over goto.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes (This was not written on Windows so CI will have to tell)
  • commit message follows commit guidelines

@addaleax
src: refactor win32 DebugProcess() to use RAII cleanup
73eab93 
Prefer more idiomatic C++ cleanup code over `goto`.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/951/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 20, 2018
@addaleax
Copy link
Member Author

addaleax commented Sep 20, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/17345/ (:heavy_check_mark:)

@addaleax addaleax added the lib / src Issues and PRs related to general changes in the lib or src directory. label Sep 20, 2018
lundibundi
lundibundi approved these changes Sep 21, 2018
View reviewed changes
Copy link
Member

@lundibundi lundibundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@lundibundi lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 21, 2018
@gireeshpunathil gireeshpunathil mentioned this pull request Sep 22, 2018
Merged
4 tasks
@addaleax
Copy link
Member Author

Landed in 59a8324

@addaleax addaleax closed this Sep 23, 2018
@addaleax addaleax deleted the debug-raii branch September 23, 2018 20:48
addaleax added a commit that referenced this pull request Sep 23, 2018
@addaleax
src: refactor win32 DebugProcess() to use RAII cleanup
59a8324 
Prefer more idiomatic C++ cleanup code over `goto`.

PR-URL: #22981
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
targos pushed a commit that referenced this pull request Sep 24, 2018
@addaleax @targos
src: refactor win32 DebugProcess() to use RAII cleanup
ab032e4 
Prefer more idiomatic C++ cleanup code over `goto`.

PR-URL: #22981
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzoz bzoz bzoz approved these changes

@lundibundi lundibundi lundibundi approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@eugeneo eugeneo eugeneo approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@addaleax @nodejs-github-bot @eugeneo @jasnell @cjihrig @tniessen @gireeshpunathil @lundibundi @bzoz