win,msi: install Boxstarter from elevated shell

[joaocgreis]

This fixes the issue described in #22645 (comment) (cc @targos).

Boxstarter asks for elevation to install packages, but not to install Boxstarter itself. If Boxstarter is already installed, the command succeeds with or without elevation. This PR changes the batch file to run all the commands from an elevated PowerShell.

LTS and semver: This is a bug fix for #22645, which is currently only in master. That PR is semver-minor without a strong case for backporting, so this one should not be backported as well even if this is semver-patch.

cc @nodejs/platform-windows @richardlau

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@joaocgreis build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/953/pipeline

[joaocgreis]

CI: https://ci.nodejs.org/job/node-test-pull-request/17349/

[targos]

Test build so we can try it: https://ci-release.nodejs.org/job/iojs+release/3775/
Edit: https://nodejs.org/download/test/v11.0.0-test201809217371a1f810/

[targos]

I tested it and it works, nice!
Rubberstamp LGTM on the actual change.

[tniessen]

This does not permamently install Boxstart itself, just the required packages, right?

[targos]

It permanently installs the Boxstarter shell

[tniessen]

Is that visible to the user prior to the installation? The MSI dialog window does not seem to say so.

[joaocgreis]

@tniessen there's a mention of Boxstarter in the shell text before installation. This installs Chocolatey and Boxstarter as system tools (which are a good thing to have I believe). The most visible part is the Boxstarter Shell that appears in the desktop. Do you think that's an issue? I could add a hackish workaround for that, but I'd rather not unless it proves to be a problem. There are links for manual steps for people that want more control over the installation.

[tniessen]

This installs Chocolatey and Boxstarter as system tools (which are a good thing to have I believe)

I agree, but it should be obvious to the user that that is going to happen, and I don't think it currently is. I opened #23003 to deal with that.

This discussion is unrelated to this PR though, the change itself LGTM.

[addaleax]

@tniessen @joaocgreis Is this ready for landing? It seems that way but I’m super unfamiliar with the subject matter so I don’t feel comfortable pushing the button just yet. :)

[tniessen]

I'd think so, but I cannot actually test the installer right now, would be great if someone else from @nodejs/platform-windows could confirm.

[joaocgreis]

This is ready to land. Both @targos and I tested this, I tested on Windows 7, 2012R2 and 10. It is possible (or even likely) that some program out there or some configuration will make the installation fail, so more testing would always be welcome. (I believe that using Chocolatey/Boxstarter is both the simplest way and the one that will cause less issues, but installing these tools is hard.)

I will land this tomorrow if no one gets to it first or finds any issue.

[joaocgreis]

Landed in 0461dd9

Thanks for your reviews @targos @tniessen @jasnell !