Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade to libuv 1.23.1 #22997

Closed
wants to merge 1 commit into from
Closed

deps: upgrade to libuv 1.23.1 #22997

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Sep 21, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/957/pipeline

@nodejs-github-bot nodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Sep 21, 2018
@addaleax addaleax mentioned this pull request Sep 21, 2018
Closed
addaleax
addaleax approved these changes Sep 21, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes: https://github.com/nodejs/node/issues/22814

@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/17356/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 21, 2018
mcollina
mcollina approved these changes Sep 21, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleax
Copy link
Member

Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/20943/

BridgeAR
BridgeAR approved these changes Sep 23, 2018
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@danbev
Copy link
Contributor

danbev commented Sep 24, 2018

Landed in 2790db5.

@danbev danbev closed this Sep 24, 2018
danbev pushed a commit that referenced this pull request Sep 24, 2018
@cjihrig @danbev
deps: upgrade to libuv 1.23.1
2790db5 
PR-URL: #22997
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request Sep 24, 2018
@cjihrig @targos
deps: upgrade to libuv 1.23.1
e5efdba 
PR-URL: #22997
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@gireeshpunathil gireeshpunathil mentioned this pull request Sep 25, 2018
Closed
@joyeecheung joyeecheung mentioned this pull request Sep 25, 2018
Closed
@Trott
Copy link
Member

Trott commented Oct 4, 2018

After talking a bit with @addaleax, I did a bisect using a series of stress tests to determine what commit introduced the unreliability for test-gc-net-timeout (and likely the other test-gc-* files). Unfortunately, the commit where the problem was introduced is the one in this PR.

Ref: https://gist.github.com/Trott/d3c3b5e4419497fdc8651ac2d5f805c7

@addaleax
Copy link
Member

addaleax commented Oct 4, 2018

Went through the individual libuv commits in nodejs/reliability#18 (comment)

@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Nov 5, 2018
@cjihrig @MylesBorins
deps: upgrade to libuv 1.23.1
a31819a 
PR-URL: nodejs#22997
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 11, 2018
@cjihrig @MylesBorins
deps: upgrade to libuv 1.23.1
b38190e 
Backport-PR-URL: #24103
PR-URL: #22997
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Nov 12, 2018
Merged
@Fishrock123 Fishrock123 mentioned this pull request Nov 15, 2018
Closed
@beevelop beevelop mentioned this pull request Nov 20, 2018
Closed
@shuhei shuhei mentioned this pull request Jan 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. libuv Issues and PRs related to the libuv dependency or the uv binding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @nodejs-github-bot @addaleax @danbev @Trott @mcollina @jasnell @BridgeAR