-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: Improve readability of help text in node --help
#23016
Conversation
I think the current text was intentional; reading from stdin is the default when no other file name is provided, and if stdin is a TTY we enter interactive mode? |
It seems the "reading from stdin" is wider than "interactive mode" (it may be a command chain), so this is a note about a partial case, not the definition of "default", and the semicolon seems valid. |
ah! I see it now, thanks for the clarification. |
@gireeshpunathil That doesn’t mean we can’t improve here … I agree that this is not immediately obvious. Maybe we could change it to something like |
I reworded the help message for better readability, PTAL. |
node --help
Re-run of failing node-test-commit-linux-containered and node-test-commit-linux/ |
rebased and started a new CI: https://ci.nodejs.org/job/node-test-pull-request/17491/ |
only one known failure under |
modified the `-` CLI option help text for improved readability. PR-URL: nodejs#23016 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
ac93f91
to
0f78b9a
Compare
modified the `-` CLI option help text for improved readability. PR-URL: #23016 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
modified the `-` CLI option help text for improved readability. PR-URL: #23016 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes