Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: close fd in doSendFileFD() #23047

Merged
merged 1 commit into from
Sep 26, 2018
Merged

http2: close fd in doSendFileFD() #23047

merged 1 commit into from
Sep 26, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Sep 24, 2018

This commit closes the file descriptor in two code paths that
return from doSendFileFD().

Fixes: #23029

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/989/pipeline

@nodejs-github-bot nodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Sep 24, 2018
mcollina
mcollina approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joyeecheung joyeecheung mentioned this pull request Sep 25, 2018
Closed
@cjihrig
Copy link
Contributor Author

cjihrig commented Sep 25, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17428/
and
Resumed green CI: https://ci.nodejs.org/job/node-test-pull-request/17431/

@cjihrig
http2: close fd in doSendFileFD()
af5d986 
This commit closes the file descriptor in two code paths that
return from doSendFileFD().

PR-URL: nodejs#23047
Fixes: nodejs#23029
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@cjihrig cjihrig merged commit af5d986 into nodejs:master Sep 26, 2018
@cjihrig cjihrig deleted the http2 branch September 26, 2018 12:27
targos pushed a commit that referenced this pull request Sep 27, 2018
@cjihrig @targos
http2: close fd in doSendFileFD()
d1826fe 
This commit closes the file descriptor in two code paths that
return from doSendFileFD().

PR-URL: #23047
Fixes: #23029
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@kjin kjin mentioned this pull request Oct 3, 2018
Closed
4 tasks
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@addaleax addaleax mentioned this pull request Oct 20, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

http2stream.respondWithFile leaks a file descriptor every time statCheck returns false.
7 participants
@cjihrig @nodejs-github-bot @mcollina @jasnell @addaleax @BridgeAR @trivikr