Forget closed http2 streams #23134
Forget closed http2 streams #23134
Conversation
nodejs-github-bot
added
c++
|
@nodejs/http2 |
|
Lgtm with green ci |
addaleax
added
the
author ready
|
I'm afraid I don't understand the test results. |
|
I can make the test run quicker by decreasing |
|
The test likely should go into test/sequential or maybe even test/pummel |
|
New CI: https://ci.nodejs.org/job/node-test-pull-request/17495/ @davedoesdev If a tests takes longer than 20s or so, you might want to consider moving it to |
|
The revised test should only take a few seconds. The new CI test failure on Linux is test.parallel/test-gc-http-client-timeout. |
|
Re-run of CI: https://ci.nodejs.org/job/node-test-pull-request/17576/ |
Decreasing maxSessionMemory lets us decrease number of iteractions before the exception occurs without the fix.
|
Those tests are failing on I notice that other PRs (e.g. https://ci.nodejs.org/job/node-test-pull-request/17567/) are also failing. Are the CI tests usually 100% pass? |
| endStream: true | ||
| }); | ||
| })); | ||
| stream.pipe(new Writable({ |
There was a problem hiding this comment.
Nit: can't we use stream.resume() instead of piping to a dummy writable?
No, there are some flaky tests. |
|
Re-run of failing node-test-commit-linux ✔️ |
|
Landed in e8121d5. |
PR-URL: #23134 Fixes: #23116 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #23134 Fixes: #23116 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #23134 Fixes: #23116 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #23116
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes