tools: unify .editorconfig rules for 2-space #23163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `doc` directory had not had any editorconfig rules applied which can lead to tab indentation in editors. This unifies the rules to use 2-space as the default. Additionally, all rules are now sorted alphabetically.
thefourtheye
approved these changes
Sep 29, 2018
lpinca
approved these changes
Sep 29, 2018
refack
approved these changes
Sep 29, 2018
addaleax
approved these changes
Oct 1, 2018
addaleax
added
the
author ready
|
Landed in 6ea507a. |
silverwind
added a commit
that referenced
this pull request
Oct 1, 2018
The `doc` directory had not had any editorconfig rules applied which can lead to tab indentation in editors. This unifies the rules to use 2-space as the default. Additionally, all rules are now sorted alphabetically. PR-URL: #23163 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 3, 2018
The `doc` directory had not had any editorconfig rules applied which can lead to tab indentation in editors. This unifies the rules to use 2-space as the default. Additionally, all rules are now sorted alphabetically. PR-URL: #23163 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThe
docdirectory had not had any editorconfig rules applied which can lead to tab indentation in editors. This unifies the rules to use 2-space as the default. Additionally, all rules are now sorted alphabetically.