Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: use connect() instead of connect.call() #23289

Closed
wants to merge 1 commit into from
Closed

net: use connect() instead of connect.call() #23289

wants to merge 1 commit into from

Conversation

JacksonTian
Copy link
Contributor

@JacksonTian JacksonTian commented Oct 6, 2018 •
edited
Loading

Use socket.connect() directly.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@JacksonTian
net: use connect() instead of connect.call()
56857a1 
Use socket.connect() directly.
@nodejs-github-bot
Copy link
Collaborator

@JacksonTian build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1138/pipeline

@nodejs-github-bot nodejs-github-bot added the net Issues and PRs related to the net subsystem. label Oct 6, 2018
@lpinca
Copy link
Member

lpinca commented Oct 6, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17663/

thefourtheye
thefourtheye approved these changes Oct 6, 2018
View reviewed changes
Copy link
Contributor

@thefourtheye thefourtheye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @watson as it was introduced by them in #12861

@trivikr
Copy link
Member

trivikr commented Oct 7, 2018

Resume: https://ci.nodejs.org/job/node-test-pull-request/17669/

watson
watson approved these changes Oct 7, 2018
View reviewed changes
Copy link
Member

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thefourtheye 👍

@danbev
Copy link
Contributor

danbev commented Oct 10, 2018

Landed in 45c70b0.

@danbev danbev closed this Oct 10, 2018
danbev pushed a commit that referenced this pull request Oct 10, 2018
@JacksonTian @danbev
net: use connect() instead of connect.call()
45c70b0 
Use socket.connect() directly.

PR-URL: #23289
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Thomas Watson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 10, 2018
@JacksonTian @targos
net: use connect() instead of connect.call()
a65bb42 
Use socket.connect() directly.

PR-URL: #23289
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Thomas Watson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Oct 10, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@JacksonTian @jasnell
net: use connect() instead of connect.call()
33a2186 
Use socket.connect() directly.

PR-URL: #23289
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Thomas Watson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

@watson watson watson approved these changes

Assignees
No one assigned
Labels
net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@JacksonTian @nodejs-github-bot @lpinca @trivikr @danbev @watson @jasnell @thefourtheye @cjihrig