-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: remove ABI guide #23303
doc: remove ABI guide #23303
Conversation
Move it to the nodejs.org repo.
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Landed in fd6a7d4. |
Move it to the nodejs.org repo. PR-URL: nodejs#23303 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Theoretically, this shouldn't have landed quite yet because the second 👍 was not from a Collaborator on the core repo. But that's OK, I'm going to add a post-facto 👍 right now! 😆 |
(This would be a possible argument for either eliminating wait times altogether or else automating more. I know there's been talk about having ncu check fast-track approvals but I'm not sure what obstacles might exist. OK, I'll stop rambling...) |
@Trott Thanks! Maybe we should edit into the request to 👍 instead of reacting to it with an emoji: Add your 👍 here to fast-track:<👍s go here> |
Move it to the nodejs.org repo. PR-URL: #23303 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Move it to the nodejs.org repo. PR-URL: #23303 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Move it to the nodejs.org repo.
Checklist