Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: read() on dir on AIX does not return EISDIR #23330

Closed
wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

An upcoming change in libuv will remove the artificial EISDIR error.
Update the test to reflect that.

Refs: libuv/libuv#2025

An upcoming change in libuv will remove the artificial EISDIR error.
Update the test to reflect that.

Refs: libuv/libuv#2025
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 8, 2018
@richardlau
Copy link
Member

We could also update the fs docs.

@richardlau richardlau mentioned this pull request Oct 8, 2018
4 tasks
@addaleax addaleax added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 8, 2018
@addaleax
Copy link
Member

addaleax commented Oct 8, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17684/

Please 👍 to approve fast-tracking.

@Trott
Copy link
Member

Trott commented Oct 8, 2018

One Linux host failed with a known-to-be-unreliable test. Here's a re-run for Linux: https://ci.nodejs.org/job/node-test-commit-linux/22170/

Trott pushed a commit to Trott/io.js that referenced this pull request Oct 8, 2018
An upcoming change in libuv will remove the artificial EISDIR error.
Update the test to reflect that.

Refs: libuv/libuv#2025

PR-URL: nodejs#23330
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member

Trott commented Oct 8, 2018

Landed in 787cbe9

jasnell pushed a commit that referenced this pull request Oct 17, 2018
An upcoming change in libuv will remove the artificial EISDIR error.
Update the test to reflect that.

Refs: libuv/libuv#2025

PR-URL: #23330
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Nov 5, 2018
An upcoming change in libuv will remove the artificial EISDIR error.
Update the test to reflect that.

Refs: libuv/libuv#2025

PR-URL: nodejs#23330
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 11, 2018
An upcoming change in libuv will remove the artificial EISDIR error.
Update the test to reflect that.

Refs: libuv/libuv#2025

Backport-PR-URL: #24103
PR-URL: #23330
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.