Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove eslint-disable from fixtures #23345

Closed
wants to merge 1 commit into from
Closed

test: remove eslint-disable from fixtures #23345

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 9, 2018 •
edited
Loading

Fixture files are not linted. Remove eslint-disable comments from
fixture files.

👍 here to fast-track

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: remove eslint-disable from fixtures
bca04dc 
Fixture files are not linted. Remove `eslint-disable` comments from
fixture files.
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1173/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 9, 2018
@Trott
Copy link
Member Author

Trott commented Oct 9, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17693/

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 9, 2018
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 9, 2018
@Trott
Copy link
Member Author

Trott commented Oct 9, 2018

Landed in c001ba6

@Trott Trott closed this Oct 9, 2018
Trott added a commit to Trott/io.js that referenced this pull request Oct 9, 2018
@Trott
test: remove eslint-disable from fixtures
c001ba6 
Fixture files are not linted. Remove `eslint-disable` comments from
fixture files.

PR-URL: nodejs#23345
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@thefourtheye
Copy link
Contributor

Would it make sense to lint fixtures as well?

targos pushed a commit that referenced this pull request Oct 10, 2018
@Trott @targos
test: remove eslint-disable from fixtures
70abcf2 
Fixture files are not linted. Remove `eslint-disable` comments from
fixture files.

PR-URL: #23345
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@targos targos mentioned this pull request Oct 10, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@Trott @jasnell
test: remove eslint-disable from fixtures
0cd180f 
Fixture files are not linted. Remove `eslint-disable` comments from
fixture files.

PR-URL: #23345
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@Trott Trott deleted the eslint-fixtures branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @nodejs-github-bot @thefourtheye @refack @cjihrig @richardlau @vsemozhetbyt @trivikr