Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: restore js2c direct dependency on config.gypi #23355

Merged
merged 1 commit into from
Oct 10, 2018
Merged

build: restore js2c direct dependency on config.gypi #23355

merged 1 commit into from
Oct 10, 2018

Conversation

refack
Copy link
Contributor

@refack refack commented Oct 9, 2018

Fixes: #23352

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1181/pipeline

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 9, 2018
@refack refack self-assigned this Oct 9, 2018
@refack refack added the regression Issues related to regressions. label Oct 9, 2018
@refack refack mentioned this pull request Oct 9, 2018
Closed
@danbev
Copy link
Contributor

danbev commented Oct 10, 2018

@refack Thanks for the quick fix!
Could you update the commit message so that it contains a black line so the travis CI build passes.

Could this be fast-tracked perhaps?

@richardlau
Copy link
Member

I think the blank line issue has been fixed in core-validate-commit (nodejs/core-validate-commit#29 (comment)) so I've restarted the Travis CI.

@danbev danbev mentioned this pull request Oct 10, 2018
Merged
2 tasks
@danbev
Copy link
Contributor

danbev commented Oct 10, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17717/

@refack refack added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 10, 2018
@refack
Copy link
Contributor Author

refack commented Oct 10, 2018

Need another 👍 for fast-tracking.

@refack
build: restore js2c direct dependency on config.gypi
484e4db 
PR-URL: nodejs#23355
Fixes: nodejs#23352
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@refack refack force-pushed the fix-js2c-config.gypi-dependenacy branch from 7bd8623 to 484e4db Compare October 10, 2018 14:43
@refack
Copy link
Contributor Author

refack commented Oct 10, 2018

Fast-tracked with 2 approvals.

@refack refack merged commit 484e4db into nodejs:master Oct 10, 2018
@refack refack deleted the fix-js2c-config.gypi-dependenacy branch October 10, 2018 14:47
targos pushed a commit that referenced this pull request Oct 10, 2018
@refack @targos
build: restore js2c direct dependency on config.gypi
e6484c2 
PR-URL: #23355
Fixes: #23352
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@targos targos mentioned this pull request Oct 10, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 11, 2018
Closed
Closed
Closed
Closed
Closed
@refack refack removed their assignment Oct 12, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@refack @jasnell
build: restore js2c direct dependency on config.gypi
ec3740c 
PR-URL: #23355
Fixes: #23352
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@addaleax addaleax addaleax approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. regression Issues related to regressions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running configure twice will most likely cause test failures
6 participants
@refack @nodejs-github-bot @danbev @richardlau @addaleax @joyeecheung