Fix crypto::Hash update method's error output #25533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
crypto
thefourtheye
approved these changes
Jan 16, 2019
sam-github
approved these changes
Jan 16, 2019
jasnell
approved these changes
Jan 17, 2019
addaleax
approved these changes
Jan 17, 2019
|
I understand that this just includes a word in the error message (the functionality is already working as expected), should this be treated as a major change? |
benjamingr
approved these changes
Jan 24, 2019
|
@thefourtheye I wouldn’t say so – we have an error code, so that should be okay. Landed in e0a3d74, and thanks for the PR! 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Feb 9, 2019
Fixes: #25487 PR-URL: #25533 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 10, 2019
Fixes: #25487 PR-URL: #25533 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
|
As the patch landed, this PR can be closed now. Thanks @amitzur for the PR 🙂 |
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #25487
This PR adds
Bufferto the list of possible input types forHash.updatein the error for invalid input type. One test was added for verifying the error output is as expected.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes