v11.10.0 proposal #26098
Merged
v11.10.0 proposal #26098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #23185 PR-URL: #24814 Reviewed-By: James M Snell <[email protected]>
- Tidy up description in docs. - Remove a second definition in the docs. - Remove unused string input parameter. - Remove duplicate "JavaScript Callstack" in error messages. PR-URL: #25749 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Prior to this commit, on non-Windows platforms, the "osVersion" value was prepended to the "machine" value. PR-URL: #25755 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Use the same JS-compatible format on both POSIX and Windows. PR-URL: #25751 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: #25743 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
For the report generation, we use `Environment::GetCurrent(isolate)` which uses `isolate->GetCurrentContext()` under the hood, thus allocates a handle. Without a `HandleScope`, this is invalid. This might not strictly be allowed inside of `OnFatalError()`, but it won’t make anything worse either. PR-URL: #25775 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
Add a check to make sure start_io_thread_async is not accidentally re-used or used when uninitialized. (This is a bit of an odd check imo, but it helped me figure out a real issue and it might do so again, so… why not?) PR-URL: #25777 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #25761 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Re-use the existing `MaybeStackBuffer` logic for `SlicedArguments`. PR-URL: #25745 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #25771 Fixes: #25760 Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
* Preserve 3 node-core checks * Preserve patch to `FileInfo.RepositoryName` * Remove TAP to logfile (unused) PR-URL: #25771 Fixes: #25760 Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
This commit combines two if statements into a single if statement. Another if statement is replaced with a ternary. PR-URL: #25744 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Use italics for words-as-words within style guide. Other minor improvements. PR-URL: #25778 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Revise inspect security information in cli.md. * Reword sentence for brevity. * Use bulleted list for clarity of options. * Eliminate personal pronoun (_you_) per style guide. PR-URL: #25779 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
The TSC has delegated authority over LTS and Current branches to the Release WG. Remove the bullet point about TSC having authority to determine that a breaking change is necessary on LTS and Current release branches. Retaining that authority would require de-chartering the Release WG. Fixes: nodejs/TSC#660 PR-URL: #25780 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Signed-off-by: gengjiawen <[email protected]> PR-URL: #25764 Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Clean up `StreamPipe::Unpipe()` to be more resilient against unexpected exceptions, in particular while executing its `MakeCallback()` line (which can fail in the presence of termination exceptions), and clean up the getter/setter part of the code to match that pattern as well (even though it should not fail as part of regular operations). PR-URL: #25716 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
The `'timeout'` event is currently not emitted on the `ClientRequest` instance when the socket timeout expires if only the `timeout` option of the agent is set. This happens because, under these circumstances, `listenSocketTimeout()` is not called. This commit fixes the issue by calling it also when only the agent `timeout` option is set. PR-URL: #25488 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Using ``` git node wpt html/webappapis/timers ``` PR-URL: #25618 Reviewed-By: James M Snell <[email protected]>
PR-URL: #25618 Reviewed-By: James M Snell <[email protected]>
PR-URL: #25782 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
- Give the glibc version entries more specific names. - Group all of the glibc version reporting together. PR-URL: #25781 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #25596 Fixes: #25593 Refs: https://developercommunity.visualstudio.com/content/problem/432157/dynamic-initializers-out-of-order.html Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
The field has been added in v0.4.0. PR-URL: #25788 Refs: b09c588#diff-1c0f1c434b17b7f8795d44a51a14320aR814 Refs: https://github.com/nodejs/node/blob/380929ec0c4c4004b522bed5e3800ebce2b68bfd/test/parallel/test-http-client-defaults.js Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Refactor _http-benchmarkers.js: * The file used a mixture of inline callbacks with the `function` keyword and arrow functions. Use arrow functions for consistency. * The file used a mixture of trailing commas and no trailing commas. Use trailing commas for consistency. PR-URL: #25803 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Refactor benchmark/common.js to consistently use arrow functions for anonymous callbacks and trailing commas. PR-URL: #25805 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PKCS#8 describes an encoding for private keys, not public keys. Using the name as a format usually refers to the PrivateKeyInfo structure it defines. (Or sometimes the EncryptedPrivateKeyInfo variant or the little-used OneAsymmetricKey extension defined in RFC 5958.) None of these structures can hold public keys to begin with. d2i_PUBKEY actually parses the public key analogous format defined in X.509, SubjectPublicKeyInfo. This function already uses "X.509" to refer to an entire certificate, so say SubjectPublicKeyInfo in the comment. (The abbreviation SPKI sometimes refers to SubjectPublicKeyInfo, e.g. in RFC 7469, but it can also an alternate S-expression-based PKI to X.509, Simple Public Key Infrastructure. To avoid confusion, stick with the expanded name.) PR-URL: #25736 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]>
Currently, there are a number of compiler warnings generated when
building the addons on Linux, for example:
make[1]: Entering directory '/node/test/addons/zlib-binding/build'
CXX(target) Release/obj.target/binding/binding.o
SOLINK_MODULE(target) Release/obj.target/binding.node
COPY Release/binding.node
make[1]: Leaving directory '/node/test/addons/zlib-binding/build'
In file included from ../binding.cc:1:
/node/src/node.h:515:51: warning:
cast between incompatible function types from
'void (*)(v8::Local<v8::Object>,
v8::Local<v8::Value>,
v8::Local<v8::Context>)' to
'node::addon_context_register_func' {aka
'void (*)(v8::Local<v8::Object>,
v8::Local<v8::Value>,
v8::Local<v8::Context>,
void*)'} [-Wcast-function-type]
(node::addon_context_register_func) (regfunc), \
^
/node/src/node.h:533:3:
note: in expansion of macro 'NODE_MODULE_CONTEXT_AWARE_X'
NODE_MODULE_CONTEXT_AWARE_X(modname, regfunc, NULL, 0)
^~~~~~~~~~~~~~~~~~~~~~~~~~~
../binding.cc:58:1:
note: in expansion of macro 'NODE_MODULE_CONTEXT_AWARE'
NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME, Initialize)
^~~~~~~~~~~~~~~~~~~~~~~~~
This commit adds the flag -Wno-cast-function-type to suppress these
warnings. With this change the warnings are not displayed anymore and
the output matches that of osx when running
'make -j8 test/addons/.buildstamp'.
PR-URL: #25663
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Throw a `DataCloneError` exception when encountering duplicate `ArrayBuffer`s or `MessagePort`s in the transfer list. Fixes: #25786 PR-URL: #25815 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Original commit message:
Optionally use halfsiphash for integer hashing.
Change-Id: Ibd14f7b3fe78635675c76ae864112e3a3a7bc701
Reviewed-on: https://chromium-review.googlesource.com/c/1382463
Commit-Queue: Yang Guo <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#58674}
Refs: v8/v8@c736883
nodejs-github-bot
added
build
targos
force-pushed
the
v11.10.0-proposal
branch
from
431a867 to
5d4aad2
Compare
targos
added a commit
that referenced
this pull request
Feb 14, 2019
Notable changes: TODO PR-URL: #26098
|
/cc @nodejs/collaborators @nodejs/tsc @nodejs/release @nodejs/build CI: https://ci.nodejs.org/job/node-test-pull-request/20779/ |
cjihrig
approved these changes
Feb 14, 2019
richardlau
approved these changes
Feb 14, 2019
BethGriggs
approved these changes
Feb 14, 2019
gdams
approved these changes
Feb 14, 2019
codebytere
approved these changes
Feb 14, 2019
Leko
approved these changes
Feb 14, 2019
BridgeAR
approved these changes
Feb 14, 2019
|
There are some weird errors in CITGM with eslint. Edit: fails on earlier versions of Node.js as well. |
Notable changes: deps: * Updated libuv to 1.26.0. * Updated npm to 6.7.0. http, http2: * `response.writeHead` now returns the response object. perf_hooks: * Implemented a histogram based API. process: * Exposed `process.features.inspector`. repl: * Added `repl.setupHistory` for programmatic repl. tls: * Introduced client "session" event. PR-URL: #26098
targos
force-pushed
the
v11.10.0-proposal
branch
from
5d4aad2 to
6e56771
Compare
|
I put the following notable changes: Release build: https://ci-release.nodejs.org/job/iojs+release/4221/ |
targos
added a commit
that referenced
this pull request
Feb 14, 2019
Notable changes: deps: * Updated libuv to 1.26.0. * Updated npm to 6.7.0. http, http2: * `response.writeHead` now returns the response object. perf_hooks: * Implemented a histogram based API. process: * Exposed `process.features.inspector`. repl: * Added `repl.setupHistory` for programmatic repl. tls: * Introduced client "session" event. PR-URL: #26098
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 14, 2019
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 14, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2019-02-14, Version 11.10.0 (Current), @targos
Notable Changes
TODO
Commits
ccf60bbad2] - assert: add internal assert.fail() (Rich Trott) #260470b4055e616] - assert: create internal/assert micro-module (Rich Trott) #2595637d207cc0c] - assert: refactor internal assert.js (Rich Trott) #259562b1f88185f] - benchmark: remove unreachable return (ZYSzys) #25883c4d16e80b7] - benchmark: refactor for consistent style (Rich Trott) #25944c4e2bbbcab] - benchmark: use consistent coding style in assert/* (Rich Trott) #2586518b344c0d2] - benchmark: refactor benchmark/common.js (Rich Trott) #2580540398fd07a] - benchmark: refactor _http-benchmarkers.js (Rich Trott) #25803d5d163d8b9] - build: export deprecated OpenSSL symbols on Windows (Richard Lau) #25991197efb7f84] - child_process: close pipe ends that are re-piped (Gireesh Punathil) #21209f87352366a] - cluster: migrate round_robin_handle to internal assert (Rich Trott) #260478c9800ce27] - crypto: include 'Buffer' in error output of Hash.update method (Amit Zur) #25533baa0865886] - crypto: don't crash X509ToObject on error (David Benjamin) #257173e010aff83] - crypto: fix malloc mixing in X509ToObject (David Benjamin) #25717da46be2542] - crypto: fix public key encoding name in comment (David Benjamin) #257368b5a2c4f61] - deps: upgrade to libuv 1.26.0 (cjihrig) #260371c5fbeab34] - deps: upgrade npm to 6.7.0 (Kat Marchán) #258043f8c22b4cb] - deps: update llhttp to 1.1.1 (Fedor Indutny) #25753823fd5b493] - (SEMVER-MINOR) deps: float fix for building HdrHistogram on Win x86 (jasnell) #25378c01bbc5258] - deps: update acorn to 6.0.7 (Michaël Zasso) #25844a6c8e40655] - deps: patch to fix *.onion MX query on c-ares (XadillaX) #258408b71464711] - deps: remove OpenSSL git and travis configuration (Sam Roberts) #25689673e434714] - deps: v8, cherry-pick 9365d09, aac2f8c, 47d34a3 (Benjamin Coe) #25429411f6fe832] - deps: cherry-pick c736883 from upstream V8 (Yang Guo)4a254a6ce4] - doc: edit N-API introductory material in Collaborator Guide (Rich Trott) #2605144fc2f6094] - doc: clarify effect of stream.destroy() on write() (Sam Roberts) #2597321e6d353af] - doc: renamed remote's name (Thang Tran) #26050e629afa6ae] - doc: fix minor typo in dgram.md (Daniel Bevenius) #26055663b6251a0] - doc: fix some nits in perf_hooks (Vse Mozhet Byt) #260229420a737fe] - doc: edit process.report related documentation (cjihrig) #25983eb4b5ea233] - doc: clarify http timeouts (Andrew Moss) #25748a225f99ea8] - doc: revise Introducing New Modules (Rich Trott) #25975f516f68032] - doc: add a sentence about REPLACEME in code changes (Lance Ball) #259613b74cc6c26] - doc: revise Collaborator Guide on reverting (Rich Trott) #25942353de0f752] - doc: fix err_synthetic issue on v11.x (sreepurnajasti) #25770cc4ae20d20] - doc: improve doc on unintended breaking changes (Rich Trott) #258871f6acbb279] - doc: document os.userInfo() throwing SystemError (Raido Kuli) #25724699d161f9e] - doc: fix machine field in example report (cjihrig) #25855618f641271] - doc: remove redundant LTS/Current information in Collaborator Guide (Rich Trott) #258427a1f166cfa] - doc: add documentation for request.path (Kei Ito) #25788f5db5090bc] - doc: remove outdated COLLABORATOR_GUIDE sentence about breaking changes (Rich Trott) #25780accb8aec35] - doc: revise inspect security info in cli.md (Rich Trott) #25779fd98d62909] - doc: revise style guide (Rich Trott) #2577860c5099f4b] - domain: avoid circular memory references (Anna Henningsen) #259932b48a381b9] - fs: remove redundant callback check (ZYSzys) #2516029c195e17f] - fs: remove useless internalFS (ZYSzys) #2516151982978eb] - http: improve performance for incoming headers (Weijia Wang) #2604190c9f1d323] - http: reduce multiple output arrays into one (Weijia Wang) #26004a5247cc180] - (SEMVER-MINOR) http: makes response.writeHead return the response (Mark S. Everitt) #25974b7fb49e70a] - http: remove redundant call to socket.setTimeout() (Luigi Pinca) #2592825c19eb1d8] - http: make timeout event work with agent timeout (Luigi Pinca) #254880899c8bb32] - http2: improve compat performance (Matteo Collina) #25567237b5e65e4] - (SEMVER-MINOR) http2: makes response.writeHead return the response (Mark S. Everitt) #259746967407b19] - inspector, trace_events: make sure messages are sent on a main thread (Eugene Ostroukhov) #24814d02ad40d42] - inspector,vm: remove --eval wrapper (Anna Henningsen) #2583232e6bb32b2] - lib: merge 'undefined' into one 'break' branch (MaleDong) #26039b2b37c631a] - lib: simplify 'umask' (MaleDong) #26035b1a8927adc] - lib: fix the typo error (MaleDong) #26032d5f4a1f2ac] - lib: save a copy of Symbol in primordials (Joyee Cheung) #26033bd932a347e] - lib: move per_context.js under lib/internal/bootstrap (Joyee Cheung) #26033f40e0fcdcb] - lib: replace 'assert' with 'internal/assert' for many built-ins (Rich Trott) #259568ade433f51] - lib: move signal event handling into bootstrap/node.js (Joyee Cheung) #2585992ca50636c] - lib: save primordials during bootstrap and use it in builtins (Joyee Cheung) #258161b8d2ca85f] - lib: remove dollar symbol for private function (MaleDong) #25590b06f2fafe7] - lib: useinternal/optionsto query--abort-on-uncaught-exception(Joyee Cheung) #258620b302e4520] - lib: fix a few minor issues flagged by lgtm (Robin Neatherway) #2587399bc0df74c] - lib: refactor ERR_SYNTHETIC (cjihrig) #257491c6fadea31] - meta: clarify EoL platform support (João Reis) #2583803ffcf76b7] - n-api: finalize during second-pass callback (Gabriel Schulhof) #259925f6a710d8d] - os,report: use UV_MAXHOSTNAMESIZE (cjihrig) #260382cbb7a85db] - (SEMVER-MINOR) perf_hooks: implement histogram based api (James M Snell) #25378e81c6c81de] - perf_hooks: only enable GC tracking when it's requested (Joyee Cheung) #258539d6291ad46] - process: refactor lib/internal/bootstrap/node.js (Joyee Cheung) #260338d3eb47d48] - process: use primordials in bootstrap/node.js (Joyee Cheung) #2603385bc64a5c9] - process: document the bootstrap process in node.js (Joyee Cheung) #26033ae21fca36b] - process: normalize process.execPath in CreateProcessObject() (Joyee Cheung) #26002614bb9f3c8] - process: normalize process.argv before user code execution (Joyee Cheung) #260009a7e883b83] - process: group main thread execution preparation code (Joyee Cheung) #26000d7bf070652] - process: move deprecation warning initialization into pre_execution.js (Joyee Cheung) #25825d7ed125fd1] - process: stub unsupported worker methods (cjihrig) #25587c8bf4327d8] - process: move process mutation into bootstrap/node.js (Joyee Cheung) #258211d76ba1b3d] - (SEMVER-MINOR) process: expose process.features.inspector (Joyee Cheung) #25819e6a4fb6d01] - process: split execution into main scripts (Joyee Cheung) #25667f4cfbf4c9e] - process: move setup of process warnings into node.js (Anto Aravinth) #25263cc253b5f2d] - process: simplify report uncaught exception logic (cjihrig) #257444c22d6eaa1] - (SEMVER-MINOR) repl: add repl.setupHistory for programmatic repl (Lance Ball) #258952c737a89d5] - repl: remove obsolete buffer clearing (Ruben Bridgewater) #257315aaeb01655] - repl: fix eval return value (Ruben Bridgewater) #25731e66cb58a9b] - repl: simplify and improve completion (Ruben Bridgewater) #25731dfd47aa1e8] - report: make more items programmatically accessible (Anna Henningsen) #2601988019b051c] - report: rename setDiagnosticReportOptions() (cjihrig) #25990c8ceece815] - report: refactor report option validation (cjihrig) #25990afb2d17c16] - report: use uv_getnameinfo() for socket endpoints (cjihrig) #259623f400310bd] - report: widen scope of #ifndef (cjihrig) #259608494a61d79] - report: remove unnecessary case block scopes (cjihrig) #259607443288c68] - report: remove empty string stream insertion (cjihrig) #259606c51ec3014] - report: include information about event loop itself (Anna Henningsen) #2590630a4e8900a] - report: print libuv handle addresses as hex (cjihrig) #259106d39a54354] - report: use libuv calls for OS and machine info (cjihrig) #259001007416596] - report: separate release metadata (Richard Lau) #25826b1e0c43abd] - report: disambiguate glibc versions (cjihrig) #25781f6c8820b46] - report: fix typo in error message (cjihrig) #25782d4631816ef] - report: use consistent format for dumpEventTime (Anna Henningsen) #25751cc22fd7be9] - report: split up osVersion and machine values (cjihrig) #25755f71d6762ca] - src: remove redundant cast in node_http2.h (gengjiawen) #25978adaa2ae70b] - src: add lock to inspectorMainThreadHandledtor (Anna Henningsen) #26010731c2731d2] - src: add WeakReference utility (Anna Henningsen) #259937ab34ae421] - src: remove unused method in class Http2Stream (gengjiawen) #25979d7ae1054ef] - src: remove redundant cast in node_file.cc (gengjiawen) #259776c6e678eaa] - src: remove unused class in node_errors.h (gengjiawen) #2598024d9e9c8b6] - src: remove redundant void (gengjiawen) #260035de103430f] - src: use NULL check macros to check nullptr (ZYSzys) #25916c47eb932bc] - src: move process.reallyExit impl into node_process_methods.cc (Joyee Cheung) #2586001bb7b7559] - src: split ownsProcessState off isMainThread (Anna Henningsen) #25881fd6ce533aa] - src: remove main_isolate (Anna Henningsen) #25823b72ec23201] - src: move public C++ APIs into src/api/*.cc (Joyee Cheung) #255410a154ff7ad] - src: move v8_platform implementation into node_v8_platform-inl.h (Joyee Cheung) #25541d342707fa7] - src: remove unusedinternalBinding('config')properties (Joyee Cheung) #25463756558617e] - src: pass cli options to bootstrap/loaders.js lexically (Joyee Cheung) #2546385d5f67efe] - src: fix return type in Hash (gengjiawen) #25936779a5773cf] - src: refactor macro to std::min in node_buffer.cc (gengjiawen) #2591976687dedce] - src: remove unused variable (cjihrig) #25481b280d90279] - src: simplify NativeModule caching and remove redundant data (Joyee Cheung) #25352469cdacd59] - src: pass along errors from StreamBase req obj creations (Anna Henningsen) #25822d6f3b8785f] - src: pass along errors from fs object creations (Anna Henningsen) #258220672c24dc3] - src: pass along errors from http2 object creation (Anna Henningsen) #25822e3fd7520d0] - src: pass along errors from tls object creation (Anna Henningsen) #25822e0af205c98] - src: nullcheck on trace controller (Gireesh Punathil) #25943c72c4b041d] - src: allow --perf-prof-unwinding-info in NODE_OPTIONS (Tom Gallacher) #25565e6a2548807] - src: allow --perf-basic-prof-only-functions in NODE_OPTIONS (Tom Gallacher) #255657cf484c656] - src: refactor SSLError case statement (Sam Roberts) #2586155a313bb31] - src: make watchdog async callback a lambda (Gireesh Punathil) #25945de9f37d314] - src: make deleted function public in agent.h (gengjiawen) #25909620d429343] - src: use bool instead of integer literal in connection_wrap.cc (gengjiawen) #259238cedfb8196] - src: refactor to nullptr in cpp code (gengjiawen) #25888f5d50342b0] - src: clean unused code in agent.h (gengjiawen) #259142d575044ff] - src: fix compiler warnings in node_buffer.cc (Daniel Bevenius) #25665015ed0b1d7] - src: remove redundant method in node_worker.h (gengjiawen) #2584944655e93dd] - src: delete unreachable code in node_perf.h (gengjiawen) #258505a66e380ff] - src: fix data type in node_crypto.cc (gengjiawen) #25889d4c4f77d31] - src: const_cast is necessary for 1.1.1, not 0.9.7 (Sam Roberts) #25861b5a8376ffe] - src: organize TLSWrap declarations by parent (Sam Roberts) #258610772ce35fb] - src: remove unused TLWrap::EnableTrace() (Sam Roberts) #25861703549665e] - src: add PrintLibuvHandleInformation debug helper (Anna Henningsen) #259052e80b912ef] - src: usevisibility("default")exports on POSIX (Jeremy Apthorp) #25893e28d891788] - src: fix race condition in\~NodeTraceBuffer(Anna Henningsen) #25896bd771d90fd] - src: remove unimplemented method in node_http2.h (gengjiawen) #2573200f8e86702] - src: use nullptr in node_buffer.cc (gengjiawen) #2582084358b5010] - src: handle errors while printing error objects (Anna Henningsen) #25834f027290542] - src: use struct as arguments to node::Assert (Anna Henningsen) #258698a8c17880e] - src: remove unused AsyncResource constructor in node.h (gengjiawen) #257937556994d83] - src: remove unused method in js_stream.h (gengjiawen) #25790882902c672] - src: pass along errors from PromiseWrap instantiation (Anna Henningsen) #25837998cea567f] - src: workaround MSVC compiler bug (Refael Ackermann) #25596b779c072d0] - src: makeStreamPipe::Unpipe()more resilient (Anna Henningsen) #257160b014d5299] - src: make deleted functions public in node.h (gengjiawen) #25764be499c3c7b] - src: simplify SlicedArguments (Anna Henningsen) #2574535454e0008] - src: fix indentation in a few node_http2 enums (Daniel Bevenius) #257613f080d12f4] - src: add debug check for inspector uv_async_t (Anna Henningsen) #257770949039d26] - src: add handle scope toOnFatalError()(Anna Henningsen) #25775d9c2690705] - src: turn ROUND_UP into an inline function (Anna Henningsen) #257433cd134cec4] - src,lib: remove deadprocess.binding()code (Anna Henningsen) #25829cb86357d22] - test: replaced anonymous fn with arrow syntax (Pushkal B) #2602964cc234a84] - test: use emitter.listenerCount() in test-http-connect (Luigi Pinca) #260316323a9fc57] - test: refactor two http client timeout tests (Luigi Pinca) #2547361330b2f84] - test: add assert test for position indicator (Rich Trott) #26024896962fd08] - test: addWorker+--profregression test (Anna Henningsen) #260113eb6f6130a] - test: capture stderr from child processes (Gireesh Punathil) #26007d123f944a2] - test: remove extraneous report validation argument (cjihrig) #25986de587bae8a] - test: refactor to block-scope (LakshmiSwethaG) #255324dca3ab23d] - test: exit sequence sanity tests (Gireesh Punathil) #25085ef9139e5a0] - test: end tls gracefully, rather than destroy (Sam Roberts) #255087e9f5ea295] - test: pin regression test for segfault on node v6.3.1 on Ubuntu 14.04.4 #8074 to TLS 1.2 (Sam Roberts) #255081b9a608dca] - test: refactor test-http-agent-timeout-option (Luigi Pinca) #25886c457d007cd] - test: clarify confusion over "client" in comment (Sam Roberts) #255081be867685c] - test: use mustCall(), not global state checks (Sam Roberts) #2550850d2c8e945] - test: use common.mustCall(), and log the events (Sam Roberts) #255081b542e8ba0] - test: use mustCall in ephemeralkeyinfo test (Sam Roberts) #25508898cf782f8] - test: send a bad record only after connection done (Sam Roberts) #25508ace267b21c] - test: do not race connection and rejection (Sam Roberts) #25508639dc07ca0] - test: do not assume tls handshake order (Sam Roberts) #25508cc6b30f4b7] - test: do not assume server gets secure connection (Sam Roberts) #25508c17a37d95a] - test: wait for TCP connect, not TLS handshake (Sam Roberts) #255081f8991fae6] - test: add util.isDeepStrictEqual edge case tests (Rich Trott) #25932baa10aeb75] - test: add BigInt test for isDeepStrictEqual (Rich Trott) #25932c866b52942] - test: remove obsolete code (Ruben Bridgewater) #25731ee3165d6e7] - test: relax expectations in test-icu-transcode (Yang Guo) #25866025a7c3e31] - test: do not fail SLOW tests if they are not slow (Yang Guo) #25868059d30e369] - test: add hasCrypto to worker-cleanexit-with-moduleload (Daniel Bevenius) #258117cb943937f] - test: refactor test-http-agent-timeout-option (Luigi Pinca) #25854cdf3e84804] - test: exclude additional test for coverage (Michael Dawson) #25833704a440d52] - test: allow coverage threshold to be enforced (Benjamin Coe) #256755bffcf6246] - test: run html/webappapis/timers WPT (Joyee Cheung) #25618579220815a] - test: pull html/webappapis/timers WPT (Joyee Cheung) #25618d683da7ffa] - test, tools: suppress addon function cast warnings (Daniel Bevenius) #256632009f18064] - test,tracing: use close event to wait for stdio (Anna Henningsen) #258948495a788c6] - tls: renegotiate should take care of its own state (Sam Roberts) #25997fb83f842a8] - tls: in-line comments and other cleanups (Sam Roberts) #258614d0b56f3f7] - tls: don't shadow the tls global with a local (Sam Roberts) #258617656d58eed] - (SEMVER-MINOR) tls: introduce client 'session' event (Sam Roberts) #258316ca8d26020] - tools: apply more stringent lint rules for benchmark code (Rich Trott) #25944c55d662bd1] - tools: replace deprecated ESLint configuration (Rich Trott) #25877e13c1850d2] - tools: update ESLint to 5.13.0 (Rich Trott) #258778d14870b15] - tools: update dmn in update-estlint.sh (Rich Trott) #25877988c7141d4] - tools: improve prerequisites for test-all-suites (Rich Trott) #25892f395728b32] - tools: exclude benchmark code from coverage report (Rich Trott) #258419d2ea1802b] - tools: add test-all-suites to Makefile (Rich Trott) #257999f1bcd44df] - tools: make test.py Python 3 compatible (Sakthipriyan Vairamani (thefourtheye)) #25767454278a701] - tools: refloat Node.js patches to cpplint.py (Refael Ackermann) #25771b9289f41af] - tools: bump cpplint.py to 3d8f6f876d (Refael Ackermann) #257719c9aefe2a0] - worker: set stack size for worker threads (Anna Henningsen) #2604923868ba45e] - worker: keep stdio after exit (Anna Henningsen) #260176c1e92817f] - worker: set up child Isolate inside Worker thread (Anna Henningsen) #260111764aae193] - worker: pre-allocate thread id (Anna Henningsen) #26011f63817fd38] - worker: refactor thread id management (Anna Henningsen) #257968db6b8a95a] - worker: move worker thread setup code into the main script (Joyee Cheung) #256675d2e064973] - worker: no throw on property access/postMessage after termination (Christopher Jeffrey) #25871508a2e7f0f] - worker: use correct ctor for error serialization (Anna Henningsen) #2595152d4b7a928] - worker: remove undocumented .onclose property (Rich Trott) #25904e70aa30ebd] - worker: add mutex lock to MessagePort ctor (Anna Henningsen) #2591155c270253b] - worker: throw for duplicates in transfer list (Anna Henningsen) #25815c959d60242] - worker,etw: only enable ETW on the main thread (Anna Henningsen) #25907