Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test, tools: suppress addon function cast warnings #25663

Closed
wants to merge 3 commits into from
Closed

test, tools: suppress addon function cast warnings #25663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ede6c4a
test, tools: suppress addon function cast warnings
danbev Jan 23, 2019
b81432d
squash!: conditionaly add -Wno-cast-function-type
danbev Jan 28, 2019
c692e51
squash!: introduce test/addons/common.gypi
danbev Jan 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/addons/async-hello-world/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/async-hooks-id/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/async-hooks-promise/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/async-resource/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/at-exit/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/buffer-free-callback/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/callback-scope/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
8 changes: 8 additions & 0 deletions test/addons/common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'conditions': [
[ 'OS in "linux freebsd openbsd solaris android aix cloudabi"', {
'cflags': ['-Wno-cast-function-type'],
}],
],
}
2 changes: 1 addition & 1 deletion test/addons/dlopen-ping-pong/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
},
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/errno-exception/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/heap-profiler/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ],
'win_delay_load_hook': 'false'
'win_delay_load_hook': 'false',
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/hello-world-esm/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/hello-world-function-export/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/hello-world/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/load-long-path/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/make-callback-domain-warning/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/make-callback-recurse/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/make-callback/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/new-target/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/node-module-version/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
3 changes: 2 additions & 1 deletion test/addons/non-node-context/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
'targets': [
{
'target_name': 'binding',
'sources': ['binding.cc']
'sources': ['binding.cc'],
'includes': ['../common.gypi'],
},
]
}
3 changes: 2 additions & 1 deletion test/addons/not-a-binding/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
'targets': [
{
'target_name': 'binding',
'sources': [ 'not_a_binding.c' ]
'sources': [ 'not_a_binding.c' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/null-buffer-neuter/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
5 changes: 3 additions & 2 deletions test/addons/openssl-binding/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@
'targets': [
{
'target_name': 'binding',
'includes': ['../common.gypi'],
'conditions': [
['node_use_openssl=="true"', {
'sources': ['binding.cc'],
'include_dirs': ['../../../deps/openssl/openssl/include'],
}]
]
}],
],
},
]
}
3 changes: 2 additions & 1 deletion test/addons/openssl-client-cert-engine/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
{
'target_name': 'testengine',
'type': 'none',
'includes': ['../common.gypi'],
'conditions': [
['OS=="mac" and '
'node_use_openssl=="true" and '
Expand All @@ -17,7 +18,7 @@
'../../../../out/<(PRODUCT_DIR)/<(openssl_product)'
]
},
}]
}],
]
}
]
Expand Down
4 changes: 2 additions & 2 deletions test/addons/parse-encoding/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/repl-domain-abort/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/stringbytes-external-exceed-max/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
3 changes: 2 additions & 1 deletion test/addons/symlinked-module/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
'targets': [
{
'target_name': 'binding',
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/uv-handle-leak/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
4 changes: 2 additions & 2 deletions test/addons/worker-addon/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
'targets': [
{
'target_name': 'binding',
'defines': [ 'V8_DEPRECATION_WARNINGS=1' ],
'sources': [ 'binding.cc' ]
'sources': [ 'binding.cc' ],
'includes': ['../common.gypi'],
}
]
}
1 change: 1 addition & 0 deletions test/addons/zlib-binding/binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
'target_name': 'binding',
'sources': ['binding.cc'],
'include_dirs': ['../../../deps/zlib'],
'includes': ['../common.gypi'],
},
]
}
4 changes: 2 additions & 2 deletions tools/doc/addon-verify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ ${files[name].replace(
targets: [
{
target_name: 'addon',
defines: [ 'V8_DEPRECATION_WARNINGS=1' ],
sources: files.map(({ name }) => name)
sources: files.map(({ name }) => name),
includes: ['../common.gypi'],
}
]
})
Expand Down