test, tools: suppress addon function cast warnings #25663

danbev · 2019-01-23T11:11:45Z

Currently, there are a number of compiler warnings generated when
building the addons on Linux, for example:

make[1]: Entering directory '/node/test/addons/zlib-binding/build'
  CXX(target) Release/obj.target/binding/binding.o
  SOLINK_MODULE(target) Release/obj.target/binding.node
  COPY Release/binding.node
make[1]: Leaving directory '/node/test/addons/zlib-binding/build'
In file included from ../binding.cc:1:
/node/src/node.h:515:51: warning:
cast between incompatible function types from
'void (*)(v8::Local<v8::Object>,
          v8::Local<v8::Value>,
          v8::Local<v8::Context>)' to
'node::addon_context_register_func' {aka
'void (*)(v8::Local<v8::Object>,
          v8::Local<v8::Value>,
          v8::Local<v8::Context>,
          void*)'} [-Wcast-function-type]
(node::addon_context_register_func) (regfunc), \
					   ^
/node/src/node.h:533:3:
note: in expansion of macro 'NODE_MODULE_CONTEXT_AWARE_X'
   NODE_MODULE_CONTEXT_AWARE_X(modname, regfunc, NULL, 0)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../binding.cc:58:1:
note: in expansion of macro 'NODE_MODULE_CONTEXT_AWARE'
 NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME, Initialize)
 ^~~~~~~~~~~~~~~~~~~~~~~~~

This commit adds the flag -Wno-cast-function-type to suppress these
warnings. With this change the warnings are not displayed anymore and
the output matches that of osx when running
make -j8 test/addons/.buildstamp

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

nodejs-github-bot · 2019-01-23T11:11:47Z

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2356/pipeline

danbev · 2019-01-23T11:39:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/20283/

danbev · 2019-01-23T17:34:42Z

Re-run of failing node-test-commit-freebsd (✔️)

bnoordhuis · 2019-01-24T15:36:30Z

I'm curious, does this actually work with clang? Older gcc versions silently accept unknown -Wno-whatever flags so no problem there but I would expect clang to complain.

danbev · 2019-01-25T04:58:05Z

I'm curious, does this actually work with clang?

I don't like writing this but, it works for me.

I'm using the following clang version:

$ clang --version
Apple LLVM version 10.0.0 (clang-1000.11.45.5)
Target: x86_64-apple-darwin18.0.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

I can run the following commands successfully and without any warnings

$ make test-addons-clean
$ make -j8 test-addons
...
[00:26|% 100|+  53|-   0]: Done

Should the added flag perhaps be conditionally only for linux OS to be on the safe side?

Currently, there are a number of compiler warnings generated when building the addons on Linux, for example: make[1]: Entering directory '/node/test/addons/zlib-binding/build' CXX(target) Release/obj.target/binding/binding.o SOLINK_MODULE(target) Release/obj.target/binding.node COPY Release/binding.node make[1]: Leaving directory '/node/test/addons/zlib-binding/build' In file included from ../binding.cc:1: /node/src/node.h:515:51: warning: cast between incompatible function types from 'void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Context>)' to 'node::addon_context_register_func' {aka 'void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Context>, void*)'} [-Wcast-function-type] (node::addon_context_register_func) (regfunc), \ ^ /node/src/node.h:533:3: note: in expansion of macro 'NODE_MODULE_CONTEXT_AWARE_X' NODE_MODULE_CONTEXT_AWARE_X(modname, regfunc, NULL, 0) ^~~~~~~~~~~~~~~~~~~~~~~~~~~ ../binding.cc:58:1: note: in expansion of macro 'NODE_MODULE_CONTEXT_AWARE' NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME, Initialize) ^~~~~~~~~~~~~~~~~~~~~~~~~ This commit adds the flag -Wno-cast-function-type to suppress these warnings. With this change the warnings are not displayed anymore and the output matches that of osx when running 'make -j8 test/addons/.buildstamp'.

danbev · 2019-01-28T07:53:23Z

Updated CI: https://ci.nodejs.org/job/node-test-pull-request/20369/

bnoordhuis

LGTM but it might be nicer to DRY it out and move it into a to-be-created test/addons/common.gypi that you include with 'includes': ['../common.gypi'].

(Could also be done for 'defines' since it always the same.)

danbev · 2019-01-30T04:55:41Z

LGTM but it might be nicer to DRY it out and move it into a to-be-created test/addons/common.gypi that you include with 'includes': ['../common.gypi'].

Yeah, that sounds much better, I'll update later today. Thanks!

danbev · 2019-02-01T04:13:07Z

Updated CI: https://ci.nodejs.org/job/node-test-pull-request/20502/

danbev · 2019-02-01T13:14:25Z

Landed in f4510c4.

Currently, there are a number of compiler warnings generated when building the addons on Linux, for example: make[1]: Entering directory '/node/test/addons/zlib-binding/build' CXX(target) Release/obj.target/binding/binding.o SOLINK_MODULE(target) Release/obj.target/binding.node COPY Release/binding.node make[1]: Leaving directory '/node/test/addons/zlib-binding/build' In file included from ../binding.cc:1: /node/src/node.h:515:51: warning: cast between incompatible function types from 'void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Context>)' to 'node::addon_context_register_func' {aka 'void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Context>, void*)'} [-Wcast-function-type] (node::addon_context_register_func) (regfunc), \ ^ /node/src/node.h:533:3: note: in expansion of macro 'NODE_MODULE_CONTEXT_AWARE_X' NODE_MODULE_CONTEXT_AWARE_X(modname, regfunc, NULL, 0) ^~~~~~~~~~~~~~~~~~~~~~~~~~~ ../binding.cc:58:1: note: in expansion of macro 'NODE_MODULE_CONTEXT_AWARE' NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME, Initialize) ^~~~~~~~~~~~~~~~~~~~~~~~~ This commit adds the flag -Wno-cast-function-type to suppress these warnings. With this change the warnings are not displayed anymore and the output matches that of osx when running 'make -j8 test/addons/.buildstamp'. PR-URL: #25663 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>

nodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Jan 23, 2019

danbev added 2 commits January 28, 2019 08:51

squash!: conditionaly add -Wno-cast-function-type

b81432d

danbev force-pushed the addons_compiler_warnings branch from 9289697 to b81432d Compare January 28, 2019 07:52

addaleax approved these changes Jan 28, 2019

View reviewed changes

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 28, 2019

bnoordhuis approved these changes Jan 29, 2019

View reviewed changes

jasnell approved these changes Jan 29, 2019

View reviewed changes

danbev removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 30, 2019

squash!: introduce test/addons/common.gypi

c692e51

richardlau approved these changes Jan 31, 2019

View reviewed changes

danbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 31, 2019

danbev closed this Feb 1, 2019

danbev deleted the addons_compiler_warnings branch February 1, 2019 13:14

targos mentioned this pull request Feb 14, 2019

v11.10.0 proposal #26098

Merged

This was referenced Feb 15, 2019

2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-nodejs#263

Closed

2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#286

Closed

2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#287

Closed

This was referenced Feb 15, 2019

2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#288

Closed

2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#289

Closed

2019-02-14 Version 11.10.0 (Current) @targos beevelop/docker-android-nodejs#290

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test, tools: suppress addon function cast warnings #25663

test, tools: suppress addon function cast warnings #25663

danbev commented Jan 23, 2019

nodejs-github-bot commented Jan 23, 2019

danbev commented Jan 23, 2019

danbev commented Jan 23, 2019

bnoordhuis commented Jan 24, 2019

danbev commented Jan 25, 2019

danbev commented Jan 28, 2019

bnoordhuis left a comment

danbev commented Jan 30, 2019

danbev commented Feb 1, 2019

danbev commented Feb 1, 2019

test, tools: suppress addon function cast warnings #25663

test, tools: suppress addon function cast warnings #25663

Conversation

danbev commented Jan 23, 2019

Checklist

nodejs-github-bot commented Jan 23, 2019

danbev commented Jan 23, 2019

danbev commented Jan 23, 2019

bnoordhuis commented Jan 24, 2019

danbev commented Jan 25, 2019

danbev commented Jan 28, 2019

bnoordhuis left a comment

Choose a reason for hiding this comment

danbev commented Jan 30, 2019

danbev commented Feb 1, 2019

danbev commented Feb 1, 2019