doc: os.userInfo throwing SystemError #25724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
raido
force-pushed
the
os-userinfo-doc
branch
2 times, most recently
from
4483091 to
b805764
Compare
Trott
reviewed
Jan 26, 2019
|
Welcome @raido and thanks for the pull request! I left some small comments. Thanks again! |
raido
force-pushed
the
os-userinfo-doc
branch
from
b805764 to
b2d5a46
Compare
jasnell
approved these changes
Jan 28, 2019
raido
force-pushed
the
os-userinfo-doc
branch
from
b2d5a46 to
01489a3
Compare
|
I see there are other methods in OS module that throw SystemErrors. Not sure if I should include all of them in this PR or open separate one for the rest of them? |
vsemozhetbyt
reviewed
Feb 2, 2019
`os.userInfo` throws an exception which was not documented in environments like: `docker run --user $(id -u): $(id -g)` PR-URL: nodejs#25724 Fixes: nodejs#25714
raido
force-pushed
the
os-userinfo-doc
branch
from
01489a3 to
71d26c4
Compare
|
Landed in d0bce9a |
vsemozhetbyt
pushed a commit
that referenced
this pull request
Feb 3, 2019
`os.userInfo()` throws an exception which was not documented in environments like: `docker run --user $(id -u): $(id -g)`. PR-URL: #25724 Fixes: #25714 Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Feb 3, 2019
`os.userInfo()` throws an exception which was not documented in environments like: `docker run --user $(id -u): $(id -g)`. PR-URL: #25724 Fixes: #25714 Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.userInfothrows an exception which was not documented in environments like:docker run --user $(id -u): $(id -g)Closes: #25714
Checklist