Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unimplemented method in node_http2.h #25732

Closed
wants to merge 1 commit into from
Closed

src: remove unimplemented method in node_http2.h #25732

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Jan 27, 2019
@gengjiawen gengjiawen force-pushed the cleanup_class_Http2Session branch from ca15e99 to e15606b Compare January 27, 2019 06:41
@danbev
Copy link
Contributor

danbev commented Jan 31, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20474/

@gengjiawen
Copy link
Member Author

@danbev can you import this change ? thanks.

@danbev
Copy link
Contributor

danbev commented Feb 4, 2019 •
edited
Loading

Re-run of CI: https://ci.nodejs.org/job/node-test-pull-request/20559/ (✔️)

@targos
Copy link
Member

targos commented Feb 4, 2019

Commit message: s/unimplement/unimplemented/

@gengjiawen gengjiawen force-pushed the cleanup_class_Http2Session branch from e15606b to e3e9d40 Compare February 4, 2019 08:12
@gengjiawen gengjiawen changed the title src: remove unimplement method in node_http2.h src: remove unimplemented method in node_http2.h Feb 4, 2019
@gengjiawen
Copy link
Member Author

@targos Fixed. Thanks.

@danbev
Copy link
Contributor

danbev commented Feb 4, 2019

Landed in c6ecbd3.

@danbev danbev closed this Feb 4, 2019
danbev pushed a commit that referenced this pull request Feb 4, 2019
@gengjiawen @danbev
src: remove unimplemented method in node_http2.h
c6ecbd3 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25732
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 6, 2019
@gengjiawen @addaleax
src: remove unimplemented method in node_http2.h
bd771d9 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25732
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gengjiawen @danbev @targos @jasnell @cjihrig @nodejs-github-bot