Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix err_synthetic issue on v11.x #25770

Closed
wants to merge 1 commit into from
Closed

doc: fix err_synthetic issue on v11.x #25770

wants to merge 1 commit into from

Conversation

sreepurnajasti
Copy link
Contributor

Fixes: #25750

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. v11.x labels Jan 28, 2019
@addaleax addaleax changed the base branch from v11.x to v11.x-staging January 28, 2019 17:15
targos
targos requested changes Jan 28, 2019
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please retarget this PR to the master branch? The heading is also wrong there.

lpinca
lpinca approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG with @targos's comment addressed.

cjihrig
cjihrig approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Targeting 11.x is the correct thing for this issue.

@addaleax
Copy link
Member

addaleax commented Feb 6, 2019

@cjihrig I don’t understand why this would be specific to v11.x?

I’d just go ahead and land this on master, tbh.

@cjihrig
Copy link
Contributor

cjihrig commented Feb 6, 2019

I'd have to double check now, but at least when I opened #25750, master was not impacted.

@addaleax
Copy link
Member

addaleax commented Feb 6, 2019

Landed on master as f31794b, cherry-picked to v11.x-staging as 353de0f :)

@addaleax addaleax closed this Feb 6, 2019
addaleax pushed a commit that referenced this pull request Feb 6, 2019
@sreepurnajasti @addaleax
doc: fix err_synthetic issue on v11.x
353de0f 
Fixes: #25750

PR-URL: #25770
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 6, 2019
@sreepurnajasti @addaleax
doc: fix err_synthetic issue on v11.x
f31794b 
Fixes: #25750

PR-URL: #25770
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@sreepurnajasti sreepurnajasti deleted the doc-err-synthetic branch February 12, 2019 04:49
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos requested changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sreepurnajasti @addaleax @cjihrig @lpinca @targos @gireeshpunathil @nodejs-github-bot