src: pass along errors from object instantiations (part II) #25822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
CI: https://ci.nodejs.org/job/node-test-pull-request/20530/ (:white_check_mark:) |
|
Any volunteers for review? :) |
|
Maybe @gireeshpunathil @joyeecheung or somebody from @nodejs/workers? |
|
sure, will have a look! |
| @@ -404,19 +410,19 @@ class FileHandle : public AsyncWrap, public StreamBase { | |||
| FileHandle& operator=(const FileHandle&&) = delete; | |||
|
|
|||
| private: | |||
| FileHandle(Environment* env, v8::Local<v8::Object> obj, int fd); | |||
|
|
|||
| // Synchronous close that emits a warning | |||
| void Close(); | |||
| void AfterClose(); | |||
|
|
|||
| class CloseReq : public ReqWrap<uv_fs_t> { | |||
| public: | |||
| CloseReq(Environment* env, | |||
There was a problem hiding this comment.
any reason why CloseReq does not follow the suit - i.e., a private constructor and a static factory?
There was a problem hiding this comment.
Just that it’s used at only one call site rather than multiple ones. I can add/use a factory constructor if you like?
There was a problem hiding this comment.
ok, I thought so. I think it is fine; doesn't look like anything beneficial of doing so.
gireeshpunathil
approved these changes
Feb 8, 2019
|
Landed in d999b55...8b79c15 |
addaleax
added a commit
that referenced
this pull request
Feb 8, 2019
PR-URL: #25822 Reviewed-By: Gireesh Punathil <[email protected]>
addaleax
added a commit
that referenced
this pull request
Feb 8, 2019
PR-URL: #25822 Reviewed-By: Gireesh Punathil <[email protected]>
addaleax
added a commit
that referenced
this pull request
Feb 8, 2019
PR-URL: #25822 Reviewed-By: Gireesh Punathil <[email protected]>
addaleax
added a commit
that referenced
this pull request
Feb 8, 2019
PR-URL: #25822 Reviewed-By: Gireesh Punathil <[email protected]>
addaleax
added a commit
that referenced
this pull request
Feb 8, 2019
PR-URL: #25822 Reviewed-By: Gireesh Punathil <[email protected]>
addaleax
added a commit
that referenced
this pull request
Feb 8, 2019
PR-URL: #25822 Reviewed-By: Gireesh Punathil <[email protected]>
addaleax
added a commit
that referenced
this pull request
Feb 8, 2019
PR-URL: #25822 Reviewed-By: Gireesh Punathil <[email protected]>
addaleax
added a commit
that referenced
this pull request
Feb 8, 2019
PR-URL: #25822 Reviewed-By: Gireesh Punathil <[email protected]>
Merged
This was referenced Feb 15, 2019
BethGriggs
pushed a commit
that referenced
this pull request
Aug 15, 2019
[This backport applied to v10.x cleanly.] Backport-PR-URL: #29123 PR-URL: #25822 Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the slightly harder-to-address cases of potentially failing
NewInstance()calls.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes