This repository has been archived by the owner on Oct 17, 2023. It is now read-only.
fix: Ensure documentation workflows behave as expected #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for noir-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
5 tasks
|
@critesjosh I believe that issue was closed by the broken workflow, which is what showed me these workflows had a problem. I'll re-open it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the documentation workflows so they behave correctly. I found that the "delete" workflow was actually attempting to close every migrated issue that was ever created. I also cleaned up the "new" workflow so it will re-open an issue if the "doc needed" label is toggled on the upstream PR.