Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Dispatch documentation notifications upon label added/removed #1404

Merged
merged 4 commits into from
Jun 5, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented May 25, 2023

Description

Problem*

Closes #1338 (replaces it)

Summary*

This combines the various documentation labeler workflows into a single workflow. It uses fixes from the upstream issue-labeler action and applies github/issue-labeler#71 and github/issue-labeler#72 patches.

This allows us to rely on the outputs of the workflow to know whether we need to open or close an issue on the docs repo.

While working on this I discovered bugs with the docs workflows so this relies on noir-lang/docs#169

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@phated phated force-pushed the phated/doc-issue-workflow branch from 99d6f67 to 57623fa Compare May 25, 2023 21:29
@phated phated marked this pull request as ready for review May 25, 2023 21:35
.github/workflows/labeler.yml Outdated Show resolved Hide resolved
.github/workflows/labeler.yml Outdated Show resolved Hide resolved
Savio-Sou
Savio-Sou previously approved these changes May 29, 2023
Copy link
Collaborator

@Savio-Sou Savio-Sou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting it tgt. The labeling part LGTM.

@signorecello feel free to merge the doc repo PR and this PR if they look ok to you.

@signorecello signorecello added this pull request to the merge queue Jun 5, 2023
Merged via the queue into master with commit f078188 Jun 5, 2023
@signorecello signorecello deleted the phated/doc-issue-workflow branch June 5, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants