-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Dispatch documentation notifications upon label added/removed #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
force-pushed
the
phated/doc-issue-workflow
branch
from
May 25, 2023 21:29
99d6f67
to
57623fa
Compare
phated
commented
May 25, 2023
phated
commented
May 25, 2023
phated
commented
May 26, 2023
phated
commented
May 26, 2023
Savio-Sou
previously approved these changes
May 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting it tgt. The labeling part LGTM.
@signorecello feel free to merge the doc repo PR and this PR if they look ok to you.
signorecello
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Closes #1338 (replaces it)
Summary*
This combines the various documentation labeler workflows into a single workflow. It uses fixes from the upstream issue-labeler action and applies github/issue-labeler#71 and github/issue-labeler#72 patches.
This allows us to rely on the outputs of the workflow to know whether we need to open or close an issue on the docs repo.
While working on this I discovered bugs with the docs workflows so this relies on noir-lang/docs#169
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.