Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Handle external libraries in compilation timing report #6750

Merged
merged 138 commits into from
Dec 11, 2024

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Dec 9, 2024

Description

Problem*

Resolves #6722

Summary*

Just pushing a draft for now to see that things are working

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@vezenovm vezenovm marked this pull request as ready for review December 9, 2024 23:02
@vezenovm vezenovm marked this pull request as draft December 9, 2024 23:04
@TomAFrench
Copy link
Member

We'd also like to track memory usage for the protocol circuits which we can pretty easily add in the same way in this PR.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Compilation Sample

Program Compilation Time
sha256_regression 0m1.474s
regression_4709 0m1.563s
ram_blowup_regression 0m17.305s
private-kernel-reset 0m9.071s
private-kernel-inner 0m2.351s
parity-root 0m0.979s
noir-contracts 3m1.503s

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Peak Memory Sample

Program Peak Memory
keccak256 81.38M
workspace 122.03M
regression_4709 333.59M
ram_blowup_regression 2.55G

@TomAFrench TomAFrench enabled auto-merge December 11, 2024 14:33
@TomAFrench TomAFrench added this pull request to the merge queue Dec 11, 2024
Merged via the queue into master with commit a2d031f Dec 11, 2024
56 checks passed
@TomAFrench TomAFrench deleted the mv/compilation-report-external branch December 11, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tracking for compilation times of important circuits in CI
2 participants