Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ivy-mode support #85

Closed
jdek opened this issue Dec 20, 2019 · 3 comments · Fixed by #87
Closed

ivy-mode support #85

jdek opened this issue Dec 20, 2019 · 3 comments · Fixed by #87
Labels
context-package-support context-ui scope-compatibility type-feature
Milestone
0.5.0

Comments

@jdek
Copy link
Contributor

jdek commented Dec 20, 2019

I think this should be relatively similar to ido. The relevant faces are (copied from spacemacs-theme):

`(ivy-current-match ((,class (:background ,highlight :inherit bold))))
`(ivy-minibuffer-match-face-1 ((,class (:inherit bold))))
`(ivy-minibuffer-match-face-2 ((,class (:foreground ,head1 :underline t))))
`(ivy-minibuffer-match-face-3 ((,class (:foreground ,head4 :underline t))))
`(ivy-minibuffer-match-face-4 ((,class (:foreground ,head3 :underline t))))
`(ivy-remote ((,class (:foreground ,cyan))))
@arcticicestudio
Copy link
Contributor

Hi @jdek 👋, thanks for your contribution 👍
Since I'm not a Emacs user: Is the corresponding GitHub repository abo-abo/swiper for these faces? I thought ivy was renamed to swiper, but after some research swiper seams to be a multi-package repository.

@jdek
Copy link
Contributor Author

jdek commented Dec 21, 2019

I think you are correct, I just get it from MELPA (https://melpa.org/#/ivy), which points to that repository. I think Ivy is the main framework thing then swiper and counsel are extensions which build upon it.

@jdek jdek mentioned this issue Dec 30, 2019
Merged
@arcticicestudio arcticicestudio added this to the 0.5.0 milestone Jan 6, 2020
@arcticicestudio
Copy link
Contributor

Reviewed #87 and added change suggestions.

arcticicestudio pushed a commit that referenced this issue Jan 7, 2020
@jdek @arcticicestudio
Add ivy-mode support (#87)
d59f37c 
Added support for the "ivy-mode" of the "ivy" package [1,2].
It makes use of background to foreground color shading as main accent
to highlight matches.

[1]: https://github.com/abo-abo/swiper
[2]: https://melpa.org/#/ivy 

Co-Authored-By: Arctic Ice Studio <[email protected]>
Closes GH-85
arcticicestudio pushed a commit that referenced this issue Jan 8, 2020
@jdek @arcticicestudio
Add ivy-mode support (#87)
2a3034b 
Added support for the "ivy-mode" of the "ivy" package [1,2].
It makes use of background to foreground color shading as main accent
to highlight matches.

[1]: https://github.com/abo-abo/swiper
[2]: https://melpa.org/#/ivy 

Co-Authored-By: Arctic Ice Studio <[email protected]>
Closes GH-85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-package-support context-ui scope-compatibility type-feature
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Add ivy-mode support
2 participants
@arcticicestudio @jdek