Add ivy-mode support #87
Conversation
|
Example:
|
|
Thanks for your contribution @jdek 👍 |
There was a problem hiding this comment.
Hi @jdek 👋, thanks for your contribution 👍
I've added some change suggestions to improve the highlighting of the added faces by making use of background colors as accent instead of underlined foreground colors.
Let me know what you think about it.
Preview with applied suggestions
Co-Authored-By: Arctic Ice Studio <[email protected]>
|
Thanks for taking a look at it, I think your suggestions are a lot better than mine. I have updated the PR using the GitHub review feature (which is cool I've never used it like this before!) |
There was a problem hiding this comment.
Great, thanks for the feedback 👍
The change suggestions are indeed one of the many awesome features that were added, makes it really easy to ensure results from discussions in PRs can be applied directly while reducing the chance for typos or copy&paste mistakes.
Going to merge the PR to include it in the next release version.
Release/Changelog ResourcesBefore
|
Added support for the "ivy-mode" of the "ivy" package [1,2]. It makes use of background to foreground color shading as main accent to highlight matches. [1]: https://github.com/abo-abo/swiper [2]: https://melpa.org/#/ivy Co-Authored-By: Arctic Ice Studio <[email protected]> Closes GH-85
I'm no designer, but this is what I ended up choosing. Fixes #85.