Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighting of "injected language fragments" is overridden #140

Closed
arcticicestudio opened this issue Feb 17, 2020 · 0 comments · Fixed by #141
Closed

Highlighting of "injected language fragments" is overridden #140

arcticicestudio opened this issue Feb 17, 2020 · 0 comments · Fixed by #141
Labels
context-syntax scope-compatibility scope-quality scope-ux type-bug
Milestone
0.11.2

Comments

@arcticicestudio
Copy link
Contributor

Currently the INJECTED_LANGUAGE_FRAGMENT editor color scheme key is set to use nord10 as foreground which overrides any language specific highlighting of “injected language fragments“, e.g. when using CSS-in-JS libraries like styled-components through the “Styled Components & Styled JSX“ plugin.

This will be fixed by removing the defined foreground color entirely so the highlighting for the specific languages will be use instead.
@arcticicestudio arcticicestudio added this to the 0.11.2 milestone Feb 17, 2020
@arcticicestudio arcticicestudio self-assigned this Feb 17, 2020
svengreb pushed a commit that referenced this issue Feb 17, 2020
@arcticicestudio
Fix highlighting of "injected language fragments"
ff057ff 
Before the `INJECTED_LANGUAGE_FRAGMENT` editor color scheme key was
set to use `nord10` as foreground which overrides any language specific
highlighting of "injected language fragments", e.g. when using CSS-in-JS
libraries like styled-components [1] through the
"Styled Components & Styled JSX“ [2] plugin.

This has been fixed by removing the defined foreground color entirely so
the highlighting for the specific languages is uses instead.

[1]: https://styled-components.com
[2]: https://plugins.jetbrains.com/plugin/9997-styled-components--styled-jsx

GH-140
@arcticicestudio arcticicestudio mentioned this issue Feb 17, 2020
Merged
arcticicestudio added a commit that referenced this issue Feb 17, 2020
@arcticicestudio
Fix highlighting of "injected language fragments" (#141)
541b358 
Before the `INJECTED_LANGUAGE_FRAGMENT` editor color scheme key was
set to use `nord10` as foreground which overrides any language specific
highlighting of "injected language fragments", e.g. when using CSS-in-JS
libraries like styled-components [1] through the
"Styled Components & Styled JSX“ [2] plugin.

This has been fixed by removing the defined foreground color entirely so
the highlighting for the specific languages is uses instead.

[1]: https://styled-components.com
[2]: https://plugins.jetbrains.com/plugin/9997-styled-components--styled-jsx

Fixes GH-140
@arcticicestudio arcticicestudio removed their assignment Feb 17, 2020
svengreb pushed a commit that referenced this issue Feb 17, 2020
@arcticicestudio
Fix highlighting of "injected language fragments" (#141)
87eb769 
Before the `INJECTED_LANGUAGE_FRAGMENT` editor color scheme key was
set to use `nord10` as foreground which overrides any language specific
highlighting of "injected language fragments", e.g. when using CSS-in-JS
libraries like styled-components [1] through the
"Styled Components & Styled JSX“ [2] plugin.

This has been fixed by removing the defined foreground color entirely so
the highlighting for the specific languages is uses instead.

[1]: https://styled-components.com
[2]: https://plugins.jetbrains.com/plugin/9997-styled-components--styled-jsx

Fixes GH-140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-syntax scope-compatibility scope-quality scope-ux type-bug
Projects
None yet
Milestone
0.11.2
Development

Successfully merging a pull request may close this issue.

Fix highlighting of "injected language fragments" nordtheme/jetbrains
1 participant
@arcticicestudio