Fix highlighting of "injected language fragments" #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the `INJECTED_LANGUAGE_FRAGMENT` editor color scheme key was set to use `nord10` as foreground which overrides any language specific highlighting of "injected language fragments", e.g. when using CSS-in-JS libraries like styled-components [1] through the "Styled Components & Styled JSX“ [2] plugin. This has been fixed by removing the defined foreground color entirely so the highlighting for the specific languages is uses instead. [1]: https://styled-components.com [2]: https://plugins.jetbrains.com/plugin/9997-styled-components--styled-jsx GH-140
svengreb
approved these changes
Feb 17, 2020
arcticicestudio
deleted the
bugix/gh-140-injected-language-fragments-highlighting
branch
svengreb
pushed a commit
that referenced
this pull request
Feb 17, 2020
Before the `INJECTED_LANGUAGE_FRAGMENT` editor color scheme key was set to use `nord10` as foreground which overrides any language specific highlighting of "injected language fragments", e.g. when using CSS-in-JS libraries like styled-components [1] through the "Styled Components & Styled JSX“ [2] plugin. This has been fixed by removing the defined foreground color entirely so the highlighting for the specific languages is uses instead. [1]: https://styled-components.com [2]: https://plugins.jetbrains.com/plugin/9997-styled-components--styled-jsx Fixes GH-140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140
Before
After