Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background color and text in tip "Gradle files have changed ..." are similar #52

Closed
singlepig opened this issue May 20, 2019 · 4 comments · Fixed by #61
Closed

Background color and text in tip "Gradle files have changed ..." are similar #52

singlepig opened this issue May 20, 2019 · 4 comments · Fixed by #61
Labels
context-ui scope-ux type-improvement
Milestone
0.7.0

Comments

@singlepig
Copy link

I can't see words in this tip clearly. It might be better to change the background color.
@singlepig
Copy link
Author

Background color value is d8dee9

@arcticicestudio
Copy link
Contributor

Hi @singlepig, thanks for your report 👍
I've also noticed these banners, but I haven't found any theme key that where I can change it's color.
I'll take another look in the course of the week and maybe create a requests in JetBrains bugtracker to allow to style these UI component.

@ice1000
Copy link

ice1000 commented Jun 12, 2019

image

Same problem

arcticicestudio added a commit that referenced this issue Jun 13, 2019
@arcticicestudio
Use nord3 as background color for editor notifiations
a53f253 
The editor color scheme provides the `NOTIFICATION_BACKGROUND` key that
allows to style the background color of notifications from the editor
that are placed right below the tab bar at the top of the editor.
Previously `nord4` was used that made the color almost unreadable since
is uses a lower contrast by default instead of pure black.
This has now been changed to use `nord3` making the actual content
readable again.

GH-52
@arcticicestudio arcticicestudio mentioned this issue Jun 13, 2019
Merged
@arcticicestudio arcticicestudio added this to the Next milestone Jun 13, 2019
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jun 13, 2019 •
edited
Loading

I've found the responsible theme key: NOTIFICATION_BACKGROUND

It's defined in the editor color scheme and not in the new UI theme and more or less a kind of legacy key (see the default bundled Darcula editor color scheme) 😄
I guess JetBrains will move these sooner or later to the UI theme (makes sense for a UI element like this), but for now it's changed in #61 to make the text readable again.

Take a look at #61 if you like to get more details and maybe check out the branch to test the change.
It will be merged and deployed with the next release version 0.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-ui scope-ux type-improvement
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Editor Notification Background Color nordtheme/jetbrains
3 participants
@singlepig @arcticicestudio @ice1000