Editor Notification Background Color #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The editor color scheme provides the `NOTIFICATION_BACKGROUND` key that allows to style the background color of notifications from the editor that are placed right below the tab bar at the top of the editor. Previously `nord4` was used that made the color almost unreadable since is uses a lower contrast by default instead of pure black. This has now been changed to use `nord3` making the actual content readable again. GH-52
svengreb
approved these changes
Jun 13, 2019
|
When can we see an update on this? |
arcticicestudio
deleted the
improvement/gh-52-editor-notification-background-color
branch
|
@ice1000 Since my time to spend for OSS is very limited (and not payed), I had no time to write the release notes and deploy v0.7.0 to the JetBrains Plugin registry. The problem this PR solved also annoys me during my day job and private coding so I'll try to push the artifact today. It'll take ~12-24h to be globally available since plugin updates need to run through JetBrains verification process before being set to "confirmed" status. |
|
Nice! |
|
Version 0.7.0 has been released and deployed to the Plugin Registry and will be available within the next 24h. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the new UI theme API was released the editor color scheme provided multiple theme keys to also style some UI elements like the editor notifications (
NOTIFICATION_BACKGROUNDlike also defined in the default bundled Darcula editor color scheme).The key allows to style the background color of notifications from the editor that are placed right below the tab bar at the top of the editor.
Previously
nord4was used that made the text almost unreadable because by default a low contrast foreground is used.This has now been changed to use
nord3making the actual text content readable again.Before
After