Support 2019.2 deprecation replacement UI theme keys #86
Milestone
Comments
arcticicestudio
added a commit
that referenced
this issue
Aug 1, 2019
The latest JetBrains product versions 2019.2 deprecated some UI them keys in favour of new keys. This broke the styles when using the Nord plugin with the latest product versions due to the missing new keys. In order to support both versions `<2019.2` as well as `>=2019.2` the new keys have been added while also keeping the deprecated ones until they'll be removed from the UI theme API. 1. Editor tabs using new keys for the active background (`underlinedTabBackground`) and when hovered (`hoverMaskColor`) and also now support customization of the bottom stripe when not focused (`inactiveUnderlineColor`). 2. Debugger tabs are now using a new key for the background color (`underlinedTabBackground`) when active. 3. The auto-completion popup now uses the same color like the `DOCUMENTATION_COLOR` attribute of the editor color scheme as well as a new key for the currently active selection (`selectionBackground`). 4. The components of the status bar now using a new key to for the background color when hovered (`hoverBackground`). GH-86
arcticicestudio
added a commit
that referenced
this issue
Aug 1, 2019
The latest JetBrains product versions 2019.2 deprecated some UI them keys in favour of new keys. This broke the styles when using the Nord plugin with the latest product versions due to the missing new keys. In order to support both versions `<2019.2` as well as `>=2019.2` the new keys have been added while also keeping the deprecated ones until they'll be removed from the UI theme API. 1. Editor tabs using new keys for the active background (`underlinedTabBackground`) and when hovered (`hoverMaskColor`) and also now support customization of the bottom stripe when not focused (`inactiveUnderlineColor`). 2. Debugger tabs are now using a new key for the background color (`underlinedTabBackground`) when active. 3. The auto-completion popup now uses the same color like the `DOCUMENTATION_COLOR` attribute of the editor color scheme as well as a new key for the currently active selection (`selectionBackground`). 4. The components of the status bar now using a new key to for the background color when hovered (`hoverBackground`). GH-86
arcticicestudio
added a commit
that referenced
this issue
Aug 1, 2019
The latest JetBrains product versions 2019.2 deprecated some UI them keys in favour of new keys. This broke the styles when using the Nord plugin with the latest product versions due to the missing new keys. In order to support both versions `<2019.2` as well as `>=2019.2` the new keys have been added while also keeping the deprecated ones until they'll be removed from the UI theme API. 1. Editor tabs using new keys for the active background (`underlinedTabBackground`) and when hovered (`hoverMaskColor`) and also now support customization of the bottom stripe when not focused (`inactiveUnderlineColor`). 2. Debugger tabs are now using a new key for the background color (`underlinedTabBackground`) when active. 3. The auto-completion popup now uses the same color like the `DOCUMENTATION_COLOR` attribute of the editor color scheme as well as a new key for the currently active selection (`selectionBackground`). 4. The components of the status bar now using a new key to for the background color when hovered (`hoverBackground`). Resolves GH-86
arcticicestudio
added a commit
that referenced
this issue
Aug 3, 2019
In version 0.8.0 (1) some new UI theme keys have been added and deprecated ones modified or removed through GH-86 and PR GH-87. This included the `ui.CompletionPopup.nonFocusedMask` key that has been set to `nord0` without a alpha layer value. Since the auto completion popup of IntelliSense if not focused but the editor itself, the overlay mask gets applied. As soon as the up or down arrow keys are pressed the popup gets the focus and therefore the mask gets removed showing the list items with correct styles. The key has been removed, the popup should be shown the same like in focused state for better readable text and easy recognition of the desired auto complete entry. References: (1) https://github.com/arcticicestudio/nord-jetbrains/releases/tag/v0.8.0 GH-88
arcticicestudio
added a commit
that referenced
this issue
Aug 3, 2019
In version 0.8.0 (1) some new UI theme keys have been added and deprecated ones modified or removed through GH-86 and PR GH-87. This included the `ui.CompletionPopup.nonFocusedMask` key that has been set to `nord0` without a alpha layer value. Since the auto completion popup of IntelliSense if not focused but the editor itself, the overlay mask gets applied. As soon as the up or down arrow keys are pressed the popup gets the focus and therefore the mask gets removed showing the list items with correct styles. The key has been removed, the popup should be shown the same like in focused state for better readable text and easy recognition of the desired auto complete entry. References: (1) https://github.com/arcticicestudio/nord-jetbrains/releases/tag/v0.8.0 Fixes GH-88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The latest JetBrains product versions 2019.2 deprecated some UI theme keys in favour of new keys. This broke the styles when using the Nord plugin with the latest product versions due to the missing new keys.
In order to support both versions
<2019.2as well as>=2019.2the new keys will be added while also keeping the deprecated ones until they'll be removed from the UI theme API.underlinedTabBackground) and when hovered (hoverMaskColor) and also now support customization of the bottom stripe when not focused (inactiveUnderlineColor).underlinedTabBackground) when active.DOCUMENTATION_COLORattribute of the editor color scheme as well as a new key for the currently active selection (selectionBackground).hoverBackground).The text was updated successfully, but these errors were encountered: