Fix unreadable completion popup list items in non-focused state #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version 0.8.0 (1) some new UI theme keys have been added and deprecated ones modified or removed through GH-86 and PR GH-87. This included the `ui.CompletionPopup.nonFocusedMask` key that has been set to `nord0` without a alpha layer value. Since the auto completion popup of IntelliSense if not focused but the editor itself, the overlay mask gets applied. As soon as the up or down arrow keys are pressed the popup gets the focus and therefore the mask gets removed showing the list items with correct styles. The key has been removed, the popup should be shown the same like in focused state for better readable text and easy recognition of the desired auto complete entry. References: (1) https://github.com/arcticicestudio/nord-jetbrains/releases/tag/v0.8.0 GH-88
svengreb
approved these changes
Aug 3, 2019
arcticicestudio
deleted the
bugfix/gh-88-invisible-text-completion-popup-non-focused-state
branch
This was referenced Aug 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v0.8.0 some new UI theme keys have been added and deprecated ones modified or removed through #86 and PR #87. This included the
ui.CompletionPopup.nonFocusedMaskkey that has been set tonord0without a alpha layer value. Since the auto completion popup of IntelliSense if not focused but the editor itself, the overlay mask gets applied. As soon as the ▲ up or ▼ down arrow keys are pressed the popup gets the focus and therefore the mask gets removed showing the list items with correct styles.The key has been removed so the popup is equal like in the focused state for better readable text and easy recognition of the desired auto completion entry.
Before
After