Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use child_process.spawn instead of child_process.exec to avoid maxBuffer exceeded #23

Closed
wangsai opened this issue Apr 13, 2014 · 7 comments

Comments

@wangsai
Copy link

wangsai commented Apr 13, 2014

exec's default maxBuffer is 200k, if the files in repository are huge, e.g. cdnjs, will cause the error Error: stdout maxBuffer exceeded.

Using spawn can avoid this error.

@notatestuser
Copy link
Owner

Could you send a PR?

@wangsai
Copy link
Author

wangsai commented Apr 13, 2014

Sorry, i'm not good at coffeescript.

@notatestuser
Copy link
Owner

js2coffee is your friend :)

@Dragony
Copy link

Dragony commented May 23, 2014

I've run into this issue as well. A quick solution would be to make the 'maxBuffer' option configurable somehow:

http://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback

@gustavohenke
Copy link

+1, also suffering from this error.

@Dragony, making it configurable would not be a good solution. spawn is much more robust, in my opinion.

@NicoleY77
Copy link

+1

@notatestuser
Copy link
Owner

Have you implemented this in your fork @NecoleYu?

notatestuser added a commit that referenced this issue Jan 22, 2018
The `exec` call in `git.coffee` will be replaced soon but this fixes the issues for now.

Closes #23.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants