Use child_process spawn instead of exec #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good to me. Is there a chance you could fix up that test case? |
gustavohenke
force-pushed
the
master
branch
from
e99fbc8 to
2a7a3cc
Compare
|
Of course! |
added 4 commits
September 26, 2014 12:41
To keep compatibility with child_process.exec(), which did create an exception when the process exited with error code, we'll do this as well.
child_process.spawn() already places quotes around arguments that have spaces, so we don't need to do this by ourselves.
|
@notatestuser I have the tests passing locally, but in Travis stuff is not going well. |
|
btw: I have created a Ubuntu VM and all tests were passing. |
|
Hmm okay, I'll give it a check. |
notatestuser
force-pushed
the
master
branch
3 times, most recently
from
8b34419 to
ab4de66
Compare
notatestuser
added a commit
that referenced
this pull request
Jan 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @notatestuser,
I tried to implement the usage of
child_process.spawnmethod instead ofchild_process.execto avoid errors as reported in #23.I'm opening this PR so we can discuss the changes and fix possible errors - unfortunately I'm a Windows developer, so I couldn't run successfully all tests (I'm hoping Travis will tell me what's wrong).
Thanks in advance!
Fixes #23