-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade npm package dependencies #100
Upgrade npm package dependencies #100
Conversation
8cfabf0
to
000f638
Compare
@notatestuser maybe we should dropped end-of-life nodejs versions like v0.10 & v0.12? I doubt if modern packages still supports nodejs > 0.4 < 0.12, maybe we can bump the nodejs engine in |
000f638
to
0fcec74
Compare
0fcec74
to
d8cd1a2
Compare
I agree but dropping old node would be more suitable for a v1.0 release. Does updating dev dependencies make the tests break on those versions? |
I think it passed the tests on all versions after v4, the issue here is we can't run the test, not the test failed. Not only Not sure what's the version bumping policy here, I think the old dependencies stocked too long, so maybe it's the chance to bump to v1.0.0? (During a long time from the previous release) BTW, I don't think it means it breaks the using on old versions, just can't run test on them, and it won't violate what the readme says test on all stable versions :) |
@notatestuser sure thing! |
Actually I'll do it, no worries. Thanks again! |
Oops ... I just pushed one second later ... |
@notatestuser and I think node in |
Most of the devDependencies were dated, ref: https://david-dm.org/notatestuser/gift?type=dev
@notatestuser maybe we should dropped end-of-life nodejs versions like v0.10 & v0.12?