-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot read property '0' of null #96
Comments
Same problem here. |
It might just be a case of that regex having to catch "HEAD" too. Could you try that and let me know if it resolves the problem? |
for me, I don't know what's the problem yet but I got that problem on this repo: github.com/mervick/emojionearea, just FYI, I may test about the HEAD you mention soon :) |
Same problem here:
|
Could you have a look into what the problem is here? A pull request to fix it would be appreciated. |
All I currently know is the problem appears with https://github.com/mervick/emojionearea, but I didn't know what's the problem to cause it yet, only some repos got this problem very recently, not sure if GitHub or git did anything. |
@janbro @MichalW @PeterDaveHello which versions of git are you using? |
@notatestuser I use git v2.7.4 and v2.14, same problem. btw, I found the problem also exists with https://github.com/zabuto/calendar (and slowly increasing on different repository) |
Got the same problem with https://github.com/shinnn/gulp-gh-pages/ on git v2.13.5 |
I have the impression that the problem occurs only with github (not bitbucket) |
Okay I noticed that the commit id/hash test is not reliable, PR #98 sent! |
#98 merged! Anyone wants to help test it? (Or even help review some related code!) |
Guys, please have a quick test with the problematic repositories mentioned above and I'll get this published. I don't want to break anyone's project. And thanks @PeterDaveHello! |
The fix worked for me! |
@notatestuser give me few more mins to test :) BTW, It'll be great if #100 can also land on the next release. |
Ran through some tests myself. Published in v0.10.1. |
…trano when installing with yarn, regardless of what gift-wrapper does. Discussion about bug: notatestuser/gift#96 "resolutions" feature in yarn: https://yarnpkg.com/lang/en/docs/selective-version-resolutions
since the gulp-gh-pages doesn't update gift dependency for a long time, I'm use the @tekd's fork as an interim solution. refrence: shinnn/gulp-gh-pages#117 notatestuser/gift#96
Found the fix to this error! node_modules\gulp-gh-pages\node_modules 2> delete gift folder under gulp-gh-pages 3> npm install gift |
Yes, the author of gulp-gh-pages should update gift to resolve shinnn/gulp-gh-pages#116 and shinnn/gulp-gh-pages#117. |
Is this patched for a Gulp3 version of |
For anyone still having this problem who happens to also be using Yarn, I added a field to "resolutions" in In my {
...other package.json stuff...,
"resolutions": {
"gift": "^0.10.2"
}
} This solved the problem for me. |
I have received same issue right now. Can anyone tell me how do i fix it? @MichalW what solution worked for you? |
This is happening when I pass "HEAD" and a merge commits hash to the diff function.
The text was updated successfully, but these errors were encountered: