Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react): update app and lib generators to support new TS solution setup #28808

Open
wants to merge 71 commits into
base: master
Choose a base branch
from
Open

feat(react): update app and lib generators to support new TS solution setup #28808

wants to merge 71 commits into from
+3,084 −527

Commits on Nov 25, 2024

  1. feat(react): update app and lib generators to support new TS solution… 

    …s setup
    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    7072123 View commit details
    Browse the repository at this point in the history

  2. feat(testing): exclude dist and eslint config from e2e tsconfig.json

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    bb70f27 View commit details
    Browse the repository at this point in the history

  3. feat(react): support ts solution setup in react libs

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c895fcd View commit details
    Browse the repository at this point in the history

  4. feat(react): remove ts solution guard from webpack, rspack, and mf ge… 

    …nerators
    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    0a9efd8 View commit details
    Browse the repository at this point in the history

  5. chore(misc): update snapshots

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    e88b3e3 View commit details
    Browse the repository at this point in the history

  6. feat(react): update app generators for remix, next, expo, rn

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    a57ee18 View commit details
    Browse the repository at this point in the history

  7. feat(nextjs): update app and lib generator to support ts solution

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    61ee4fc View commit details
    Browse the repository at this point in the history

  8. feat(react): update extends for tsconfig files

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    5225228 View commit details
    Browse the repository at this point in the history

  9. feat(react): remove ts solution guard from expo/rn

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c5f6a8d View commit details
    Browse the repository at this point in the history

  10. feat(js): ignore nextjs projects for project inference

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    796abec View commit details
    Browse the repository at this point in the history

  11. fix(nextjs): fix generate tsconfig for apps

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    e3c8b32 View commit details
    Browse the repository at this point in the history

  12. fix(nextjs): skip project.json for next apps

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    5d9d5a6 View commit details
    Browse the repository at this point in the history

  13. fix(react): skip project.json for remix apps

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    738e831 View commit details
    Browse the repository at this point in the history

  14. fix(misc): fix misc issues

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    6edb934 View commit details
    Browse the repository at this point in the history

  15. fix(react): use rspack version in sync with rest of nx

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    740e08e View commit details
    Browse the repository at this point in the history

  16. feat(react): support ts solution setup for react libs

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    407e361 View commit details
    Browse the repository at this point in the history

  17. fix(react): move linter to after package.json is created so the proje… 

    …ct is there
    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    6a0952d View commit details
    Browse the repository at this point in the history

  18. feat(react): update generators to not add ts plugin by default so int… 

    …egrate style still works
    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    df9211d View commit details
    Browse the repository at this point in the history

  19. fix(nextjs): update local path alias to account for not using src

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    77fa88c View commit details
    Browse the repository at this point in the history

  20. chore(misc): update schema in docs

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    79c5a9f View commit details
    Browse the repository at this point in the history

  21. chore(misc): fix issues after rebase

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    b4428e3 View commit details
    Browse the repository at this point in the history

  22. chore(misc): update failing tests

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    ca26661 View commit details
    Browse the repository at this point in the history

  23. fix(react): fix @type/react-dom version

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    247d1a5 View commit details
    Browse the repository at this point in the history

  24. feat(nextjs): update app schema to allow --linter=none

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    60a36e2 View commit details
    Browse the repository at this point in the history

  25. feat(misc): change generator defaults back

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    0422fa2 View commit details
    Browse the repository at this point in the history

  26. fix(nextjs): support ts solution with custom server

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    17bf0fc View commit details
    Browse the repository at this point in the history

  27. feat(misc): do not generate tsconfig for apps preset when --js is used

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    9f1ad0b View commit details
    Browse the repository at this point in the history

  28. chore(misc): generate workspaces with eslint for e2e tests by default

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    665239d View commit details
    Browse the repository at this point in the history

  29. chore(misc): e2e tests use prettier by default

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    2f871da View commit details
    Browse the repository at this point in the history

  30. feat(core): add formatter to CNW option

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    5957d5f View commit details
    Browse the repository at this point in the history

  31. fix(testing): use moduleResolution as node10 for Cypress projects

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    fd7f14c View commit details
    Browse the repository at this point in the history

  32. fix(react): pass formatter option from react app generators to js init

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    2891129 View commit details
    Browse the repository at this point in the history

  33. feat(misc): update outDir for react projects to out-tsc/<name> to avo… 

    …id conflict with bundlers
    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    572d860 View commit details
    Browse the repository at this point in the history

  34. feat(core): remove tsconfig from being generated with --preset=apps

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    7c47181 View commit details
    Browse the repository at this point in the history

  35. Revert "feat(misc): do not generate tsconfig for apps preset when --j… 

    …s is used"

This reverts commit a9ea5de.
    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c9c4069 View commit details
    Browse the repository at this point in the history

  36. feat(react): add ts solution support to module federation

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    65f83d7 View commit details
    Browse the repository at this point in the history

  37. feat(react): add rootDir when src directory is used

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    7e344d0 View commit details
    Browse the repository at this point in the history

  38. feat(bundling): turn off extract license for rspack

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    f1b8109 View commit details
    Browse the repository at this point in the history

  39. feat(nextjs): scope include to src

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    87b2b94 View commit details
    Browse the repository at this point in the history

  40. feat(misc): remove project.json from e2e projects

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    12a9951 View commit details
    Browse the repository at this point in the history

  41. chore(misc): update rspack snapshots

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    ff1c106 View commit details
    Browse the repository at this point in the history

  42. feat(core): prompt for linter for react

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    46da2c9 View commit details
    Browse the repository at this point in the history

  43. fix(react): generate library correctly

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    6d62802 View commit details
    Browse the repository at this point in the history

  44. feat(core): add --workspaces flag to opt-in to use the ts solution se… 

    …tup for the react stack
    @leosvelperez @jaysoo
    leosvelperez authored and jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    b37a5dc View commit details
    Browse the repository at this point in the history

  45. Update packages/react/src/generators/application/files/base-vite/tsco… 

    …nfig.app.json__tmpl__

Co-authored-by: Nicholas Cunningham <[email protected]>
    @jaysoo @ndcunningham
    jaysoo and ndcunningham committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c9f1d80 View commit details
    Browse the repository at this point in the history

  46. Update packages/react/src/generators/application/files/base-rspack/ts… 

    …config.app.json__tmpl__

Co-authored-by: Nicholas Cunningham <[email protected]>
    @jaysoo @ndcunningham
    jaysoo and ndcunningham committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    3e63e40 View commit details
    Browse the repository at this point in the history

  47. Update packages/react/src/generators/application/files/base-webpack/t… 

    …sconfig.app.json__tmpl__

Co-authored-by: Nicholas Cunningham <[email protected]>
    @jaysoo @ndcunningham
    jaysoo and ndcunningham committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    13ed2ed View commit details
    Browse the repository at this point in the history

  48. fix(js): ignore next projects with next.config.ts

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    fa9a1fa View commit details
    Browse the repository at this point in the history

  49. Update packages/detox/src/generators/application/lib/add-project.ts 

    Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
    @jaysoo @leosvelperez
    jaysoo and leosvelperez committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    b601f3a View commit details
    Browse the repository at this point in the history

  50. Update packages/expo/src/generators/application/lib/add-e2e.ts 

    Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
    @jaysoo @leosvelperez
    jaysoo and leosvelperez committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    4ee8ecc View commit details
    Browse the repository at this point in the history

  51. Update packages/expo/src/generators/application/lib/add-e2e.ts 

    Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
    @jaysoo @leosvelperez
    jaysoo and leosvelperez committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    0c41d8d View commit details
    Browse the repository at this point in the history

  52. Update packages/remix/src/generators/application/lib/add-e2e.ts 

    Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
    @jaysoo @leosvelperez
    jaysoo and leosvelperez committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    77ad07c View commit details
    Browse the repository at this point in the history

  53. Update packages/react/src/generators/library/lib/create-files.ts 

    Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
    @jaysoo @leosvelperez
    jaysoo and leosvelperez committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c55b1d1 View commit details
    Browse the repository at this point in the history

  54. Update packages/expo/src/generators/library/library.ts 

    Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
    @jaysoo @leosvelperez
    jaysoo and leosvelperez committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    7bdfe6d View commit details
    Browse the repository at this point in the history

  55. Update packages/expo/src/generators/application/lib/add-project.ts 

    Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
    @jaysoo @leosvelperez
    jaysoo and leosvelperez committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    61217ae View commit details
    Browse the repository at this point in the history

  56. chore(react): cleanup

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    24a8a16 View commit details
    Browse the repository at this point in the history

  57. chore(react): cleanup lib generator

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    2572b82 View commit details
    Browse the repository at this point in the history

  58. chore(react): cleanup

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    5e2bae2 View commit details
    Browse the repository at this point in the history

  59. fix(js): skip typecheck and echo error when noEmit is set on a refere… 

    …nced project
    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    19ce9f7 View commit details
    Browse the repository at this point in the history

  60. feat(react): add app ref back to e2e project

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    5f83720 View commit details
    Browse the repository at this point in the history

  61. fix(react): generate e2e projects with implicit dependencies

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    cb85250 View commit details
    Browse the repository at this point in the history

  62. chore(react): align prompt options for all react generators

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    51290a6 View commit details
    Browse the repository at this point in the history

  63. feat(react): ensure projectType and tags are added

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c1d55a8 View commit details
    Browse the repository at this point in the history

  64. feat(react): add sourceRoot to package.json

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    db5cb3c View commit details
    Browse the repository at this point in the history

  65. fix(react): add sourceRoot to e2e projects

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    39848e2 View commit details
    Browse the repository at this point in the history

  66. Update packages/expo/src/generators/application/lib/add-e2e.ts 

    Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
    @jaysoo @leosvelperez
    jaysoo and leosvelperez committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    7614e5c View commit details
    Browse the repository at this point in the history

  67. Update packages/next/src/generators/application/lib/add-e2e.ts 

    Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
    @jaysoo @leosvelperez
    jaysoo and leosvelperez committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    f9b4b64 View commit details
    Browse the repository at this point in the history

  68. Update packages/remix/src/generators/application/lib/add-e2e.ts 

    Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
    @jaysoo @leosvelperez
    jaysoo and leosvelperez committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    8d1369e View commit details
    Browse the repository at this point in the history

  69. Update packages/react/src/generators/application/lib/add-e2e.ts 

    Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
    @jaysoo @leosvelperez
    jaysoo and leosvelperez committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    fa2ef85 View commit details
    Browse the repository at this point in the history

  70. Update packages/next/src/generators/application/lib/add-e2e.ts 

    Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
    @jaysoo @leosvelperez
    jaysoo and leosvelperez committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    fdf9445 View commit details
    Browse the repository at this point in the history

  71. chore(misc): fix bad rebase

    @jaysoo
    jaysoo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    eac89e6 View commit details
    Browse the repository at this point in the history