Simpler integration of config and the stdlib flag package #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I follow, want to see the changes on the https://github.com/bitly/nsq side before we land? |
|
👍 |
mreiferson
added a commit
that referenced
this pull request
Aug 24, 2015
Simpler integration of config and the stdlib flag package
|
PR on the nsq side will be forthcoming |
|
ohh so thoughtful of you. thank you @jehiah <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables simpler integration between the
Configstruct and theflagpackage which will make example consumers fromnsqeasier to use outside of that repo.RFR @mreiferson
cc: @Dieterbe