utilities: use nsq.ConfigFlag #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jehiah
force-pushed
the
cli_utilities_config_flag_640
branch
from
ad51c16 to
7db7687
Compare
|
RFR @mreiferson This is the minimal change needed; I'd love to move a bunch more flag initialization out of the global scope and into |
mreiferson
added a commit
that referenced
this pull request
Aug 25, 2015
utilities: use nsq.ConfigFlag
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the utility scripts to leverage nsq.ConfigFlag introduced in nsqio/go-nsq#155