nsqd: check response message size is positive #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyxning
force-pushed
the
pre_check_for_msg_size
branch
3 times, most recently
from
af21f38 to
954e386
Compare
|
This change looks obviously correct. I think the commit title could be more specific - this is for reading a response message. Perhaps "check response message size is positive" |
andyxning
force-pushed
the
pre_check_for_msg_size
branch
4 times, most recently
from
9f320ad to
c4f433f
Compare
andyxning
force-pushed
the
pre_check_for_msg_size
branch
from
c4f433f to
82f8d10
Compare
ploxiln
changed the title
ploxiln
reviewed
Sep 26, 2019
| - 1.11.x | ||
| - 1.12.x | ||
| - 1.13.x |
There was a problem hiding this comment.
this is sort of throwing in an unrelated change ... but also seems fine
There was a problem hiding this comment.
@ploxiln I bumped travis ci golang version to 1.13.x to resolve travis ci error when against 1.10.x. Since Golang 1.13 has been released, this bump should be fine. :)
mreiferson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pre check for msg size before
makea slice.We have encountered a panic in
make([]byte, msgSize)withpanic: runtime error: makeslice: len out of range. We have bounded the max message size by 20MB. So, it seems that make function should not panic.I have test that when
makewith a negative length,makewill panic withpanic: runtime error: makeslice: len out of range.