Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increased allowable channel and topic name length to 64 characters #36

Merged
merged 1 commit into from
May 28, 2014

Conversation

svmehta
Copy link
Contributor

@svmehta svmehta commented May 28, 2014

Relates to nsqio/nsq#355

@mreiferson
Copy link
Member

@svmehta - Thanks for this.

This is the correct change, unfortunately we're in a bit of a bind right now in that we merged #30, which means that nsqio/nsq#357 needs to be merged in order for NSQ to compile against the new go-nsq public API.

But, in nsqio/nsq#357, we no longer depend on go-nsq for the topic/channel name functions you've modified here (the NSQ repo will have its own copy).

What does this mean? We'll need another pull request on the NSQ repo side when nsqio/nsq#357 is merged, that's all.

Thanks again for your contribution.

@svmehta
Copy link
Contributor Author

svmehta commented May 28, 2014

ok will wait on you guys to merge in #357 and submit a new pull request at that time

@mreiferson
Copy link
Member

thanks

mreiferson added a commit that referenced this pull request May 28, 2014
increased allowable channel and topic name length to 64 characters
@mreiferson mreiferson merged commit 2cdc7dc into nsqio:master May 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants