nsqd: topic name length and channel name length

[svmehta]

We find ourself in need of larger topic and channel name lengths (https://github.com/bitly/go-nsq/blob/97ea060927af3af0ad2c25debf94014a22e891ca/protocol.go#L30).

They are currently capped at 32 characters, what's the design reasoning behind these limits?

128 characters would be ideal for our application. Even 64 would help.

Thanks!

[mreiferson]

hi @svmehta - there is no legitimate technical reason why they cannot be longer, it was more of a visual aesthetic issue in the variety of places we end up displaying them.

I've often thought about increasing the limit, now is as good a time as any if you're interested in sending a PR.

Note that most client libraries do client-side validation of topic/channel names, so most would need to be patched as well if this change was made.

cc @jehiah for input

[jehiah]

I agree that 32 is/was arbitrary, and i'm ok going to 64. I'll also mention that some needs to communicate information about the client via channel name (the only spot where this was originally possible) are also now handled by the ability for clients to report a 'user agent' string along with other identify when subscribing.

[mreiferson]

@svmehta - we merged #357 if you want to go ahead and make this change

[mreiferson]

fixed in #358