Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increased allowable channel and topic name length #358

Merged
merged 1 commit into from
May 28, 2014

Conversation

svmehta
Copy link
Contributor

@svmehta svmehta commented May 28, 2014

No description provided.

mreiferson added a commit that referenced this pull request May 28, 2014
increased allowable channel and topic name length
@mreiferson mreiferson merged commit 0b5d51b into nsqio:master May 28, 2014
@yujinqiu
Copy link

@mreiferson
We use NSQ in production environment and find 64 is not long enough for us, 128 will be good.
Can we make TopicName and ChannelName length configurable with default length 64 ?

@mreiferson
Copy link
Member

@yujinqiu we applied a limit here because after a certain length they get unwieldy to display, etc. We think it promotes good naming.

However, there's no technical reason this needs to be 64, so if you are persuasive in your arguments, I suppose we would consider increasing it.

@yujinqiu
Copy link

yujinqiu commented Aug 2, 2016

@mreiferson thanks for you reply. In our use case we monitor different domains and domain's path, to separate domains we use domain/path as topic name. sometimes path will reach 64 bytes limit, so we want it to be configurable and use 64 bytes as default for downside compatibility. please consider this feature, or I have to change this value and recompile it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants