[OnHold|Feat] Add PhpStan

.editorconfig

@@ -17,3 +17,11 @@ trim_trailing_whitespace = false
 
 [*.yml]
 indent_size = 2
+
+[*.php]
+ij_php_align_phpdoc_comments = false
+ij_php_align_phpdoc_param_names = false
+ij_php_phpdoc_use_fqcn = true
+ij_php_space_after_unary_not = true
+ij_php_force_short_declaration_array_style = true
+ij_php_comma_after_last_array_element = true

composer.json

@@ -15,26 +15,27 @@
         "ext-json": "*",
         "composer/composer": "^1.7",
         "league/container": "^3.2",
+        "nunomaduro/larastan": "^0.3.17",
         "object-calisthenics/phpcs-calisthenics-rules": "^3.5",
         "phploc/phploc": "^5.0",
+        "phpstan/phpstan": "^0.11.12",
+        "phpstan/phpstan-strict-rules": "^0.11.1",
         "sensiolabs/security-checker": "^6.0",
+        "squizlabs/php_codesniffer": "^3.4",
         "symfony/console": "^4.2",
-        "symfony/finder": "^4.2",
-        "symplify/coding-standard": "^6.0",
-        "symplify/easy-coding-standard": "^6.0",
-        "symplify/package-builder": "^6.0"
+        "symfony/finder": "^4.2"
     },
     "require-dev": {
         "illuminate/console": "^5.8",
+        "illuminate/database": "^5.8",
         "illuminate/support": "^5.8",
         "localheinz/phpstan-rules": "^0.10.0",
-        "phpstan/phpstan-strict-rules": "^0.11",
+        "mockery/mockery": "^1.0",
+        "phpunit/phpunit": "^8.0",
         "roave/no-floaters": "^1.1",
-        "phpstan/phpstan": "^0.11.5",
         "symfony/var-dumper": "^4.2",
-        "thecodingmachine/phpstan-strict-rules": "^0.11.0",
-        "phpunit/phpunit": "^8.0",
-        "mockery/mockery": "^1.0"
+        "symplify/easy-coding-standard": "^6.0",
+        "thecodingmachine/phpstan-strict-rules": "^0.11.0"
     },
     "autoload-dev": {
         "psr-4": {
@@ -65,7 +66,7 @@
         "ecs:test": "ecs check src --ansi --config vendor/symplify/easy-coding-standard/config/set/clean-code.yaml",
         "phpstan:test": "phpstan analyse --ansi",
         "phpunit:test": "phpunit --colors=always",
-        "insights": "bin/phpinsights analyse --ansi -v --no-interaction --min-quality=85.7 --min-architecture=76.2 --min-style=97.8",
+        "insights": "bin/phpinsights analyse --ansi -v --no-interaction --min-quality=90.0 --min-architecture=80.0 --min-style=97.8",
         "test": [
             "@phpstan:test",
             "@ecs:test",

docs/contribute.md

@@ -2,10 +2,7 @@
 
 The project is under development. As such, any help is welcome!
 
-1. [Create a new insight from scratch](#create-a-new-insight)
-2. [Add a new insight from PHP CS Sniff](#add-a-new-insight-from-php-cs-sniff)
-3. [Create or improve create a preset for your favorite framework](#create-or-improve-create-a-preset-for-your-favorite-framework)
-4. [Create the test suite](#create-the-test-suite)
+[[TOC]]
 
 ## Create a new `Insight`
 
@@ -129,3 +126,10 @@ final class Preset implements PresetContract
     }
 }
 ```
+
+## Create a new `Formatter`
+
+The package has support for formatting the result. 
+All formats implements the contract `src/Application/Console/Contracts/Formatter`.
+
+You are welcome to contribute with new formats or improve on the ones we already have.

docs/get-started.md

@@ -53,6 +53,31 @@ In laravel, launch command as usual with your path:
 php artisan insights path/to/analyse
 ```
 
+## Formatting the output
+
+For changing the output format you can add the `format` flag. The following formats are supported:
+
+- console
+- json
+
+```bash
+./vendor/bin/phpinsights analyse --format=json
+```
+
+## Saving output to file
+
+You can pipe the result to a file or to anywhere you like. 
+A common use case is parsing the output formatted as json to a json file.
+
+```bash
+./vendor/bin/phpinsights analyse --format=json > test.json
+```
+
+When piping the result remember to add the no interaction flag `-n`, as the part where you need to interact is also getting piped. (the json format does not have any interaction)
+While piping data, if you want the progress bar to refresh itself instead of printing a new one, add the `--ansi` flag.
+
+
+
 ## Allowed memory size of X bytes exhausted
 
 If you encounter the error `Allowed memory size of XXXXX bytes exhausted`, the current workaround is to increase the memory limit:

phpinsights.php

@@ -2,7 +2,10 @@
 
 declare(strict_types=1);
 
+use NunoMaduro\PhpInsights\Domain\Insights\ForbiddenDefineGlobalConstants;
+use NunoMaduro\PhpInsights\Domain\Sniffs\ForbiddenSetterSniff;
 use PHP_CodeSniffer\Standards\Generic\Sniffs\Files\LineLengthSniff;
+use SlevomatCodingStandard\Sniffs\TypeHints\DisallowMixedTypeHintSniff;
 
 return [
 
@@ -46,6 +49,25 @@
         LineLengthSniff::class => [
             'lineLimit' => 80,
             'absoluteLineLimit' => 120,
+            'ignoreComments' => true,
+        ],
+        DisallowMixedTypeHintSniff::class => [
+            'exclude' => [
+                'src/Domain/Reflection.php',
+                'src/Domain/Details.php',
+            ],
+        ],
+        ForbiddenSetterSniff::class => [
+            'exclude' => [
+                'src/Domain/Reflection.php',
+                'src/Domain/Details.php',
+            ],
+        ],
+        ForbiddenDefineGlobalConstants::class => [
+            'ignore' => [
+                'PHP_CODESNIFFER_VERBOSITY',
+                'PHP_CODESNIFFER_CBF',
+            ],
         ],
     ],
 

phpstan.neon.dist

@@ -23,6 +23,7 @@ parameters:
         - '#Language construct isset\(\) should not be used#'
         - '#Access to an undefined property PHP_CodeSniffer\\Config::\$standards.#'
         - '#Access to an undefined property PHP_CodeSniffer\\Sniffs\\Sniff::\$#'
+        - '#NunoMaduro\\PhpInsights\\Application\\Console\\Formatters\\Json has an unused parameter \$input#'
     autoload_files:
         - %rootDir%/../../squizlabs/php_codesniffer/autoload.php
     reportUnmatchedIgnoredErrors: false

schema.json

@@ -0,0 +1,101 @@
+{
+    "$schema": "http://json-schema.org/draft-07/schema#",
+    "type": "object",
+    "readOnly": true,
+    "title": "The JSON format for phpinsights",
+    "required": [
+        "summary",
+        "Code",
+        "Complexity",
+        "Architecture",
+        "Style",
+        "Security"
+    ],
+    "definitions": {
+        "percentage": {
+            "type": "number",
+            "minimum": 0,
+            "maximum": 100
+        },
+        "insight": {
+            "type": "object",
+            "required": [
+                "title",
+                "insightClass"
+            ],
+            "properties": {
+                "title": {
+                    "type": "string"
+                },
+                "insightClass": {
+                    "type": "string"
+                },
+                "file": {
+                    "type": "string"
+                },
+                "line": {
+                    "type": "integer",
+                    "minimum": 1
+                },
+                "message": {
+                    "type": "string"
+                }
+            }
+        }
+    },
+    "properties": {
+        "summary": {
+            "$id": "#/properties/summary",
+            "type": "object",
+            "title": "The Summary Schema",
+            "properties": {
+                "code": {
+                    "$ref": "#/definitions/percentage"
+                },
+                "complexity": {
+                    "$ref": "#/definitions/percentage"
+                },
+                "architecture": {
+                    "$ref": "#/definitions/percentage"
+                },
+                "style": {
+                    "$ref": "#/definitions/percentage"
+                },
+                "security issues": {
+                    "type": "integer",
+                    "minimum": 0
+                }
+            }
+        },
+        "Code": {
+            "type": "array",
+            "items": {
+                "$ref": "#/definitions/insight"
+            }
+        },
+        "Complexity": {
+            "type": "array",
+            "items": {
+                "$ref": "#/definitions/insight"
+            }
+        },
+        "Architecture": {
+            "type": "array",
+            "items": {
+                "$ref": "#/definitions/insight"
+            }
+        },
+        "Style": {
+            "type": "array",
+            "items": {
+                "$ref": "#/definitions/insight"
+            }
+        },
+        "Security": {
+            "type": "array",
+            "items": {
+                "$ref": "#/definitions/insight"
+            }
+        }
+    }
+}

src/Application/Console/Analyser.php

@@ -4,9 +4,11 @@
 
 namespace NunoMaduro\PhpInsights\Application\Console;
 
+use NunoMaduro\PhpInsights\Application\Console\Contracts\Formatter;
 use NunoMaduro\PhpInsights\Domain\Insights\InsightCollectionFactory;
 use NunoMaduro\PhpInsights\Domain\MetricsFinder;
 use NunoMaduro\PhpInsights\Domain\Results;
+use Symfony\Component\Console\Output\OutputInterface;
 
 /**
  * @internal
@@ -21,7 +23,7 @@ final class Analyser
     /**
      * Analyser constructor.
      *
-     * @param  \NunoMaduro\PhpInsights\Domain\Insights\InsightCollectionFactory  $insightCollectionFactory
+     * @param \NunoMaduro\PhpInsights\Domain\Insights\InsightCollectionFactory $insightCollectionFactory
      */
     public function __construct(InsightCollectionFactory $insightCollectionFactory)
     {
@@ -31,28 +33,27 @@ public function __construct(InsightCollectionFactory $insightCollectionFactory)
     /**
      * Analyse the given dirs.
      *
-     * @param  \NunoMaduro\PhpInsights\Application\Console\Style  $style
-     * @param  array<string, array>  $config
-     * @param  string  $dir
+     * @param Formatter $formatter
+     * @param array<string, array> $config
+     * @param string $dir
+     * @param OutputInterface $consoleOutput
      *
      * @return  \NunoMaduro\PhpInsights\Domain\Results
      */
-    public function analyse(Style $style, array $config, string $dir): Results
+    public function analyse(
+        Formatter $formatter,
+        array $config,
+        string $dir,
+        OutputInterface $consoleOutput
+    ): Results
     {
         $metrics = MetricsFinder::find();
 
-        $insightCollection = $this->insightCollectionFactory->get($metrics, $config, $dir);
+        $insightCollection = $this->insightCollectionFactory
+            ->get($metrics, $config, $dir, $consoleOutput);
 
-        $results = $insightCollection->results();
+        $formatter->format($insightCollection, $dir, $metrics);
 
-        $style->header($results, $dir)
-            ->code($insightCollection, $results)
-            ->complexity($insightCollection, $results)
-            ->architecture($insightCollection, $results)
-            ->misc($results);
-
-        $style->issues($insightCollection, $metrics, $dir);
-
-        return $results;
+        return $insightCollection->results();
     }
 }