Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Automation in Windows Console: revert for 2019.3 #10684

Merged
merged 11 commits into from
Jan 14, 2020

Conversation

codeofdusk
Copy link
Contributor

@codeofdusk codeofdusk commented Jan 14, 2020

Link to issue number:

Completes #10682.

Summary of the issue:

It was decided to revert to legacy console support for 2019.3, but various UI and user guide elements remain from #9771.

Description of how this pull request fixes the issue:

  • The auto config setting is reverted to 2019.2 behavior (i.e. it maps to legacy).
  • The UI is returned to 2019.2 state (i.e. a simple checkbox). We really should move users to UIA once it becomes the default, and users who turn on UIA to experiment during development and then switch back to legacy wouldn’t automatically be upgraded.
  • References to “legacy” consoles removed from UI and user guide.

Testing performed:

Tested an upgrade from NVDA 2019.2.1 (stable) to this PR. Insured that legacy console is used by default and the UIA checkboxes are functional.

Known issues with pull request:

None.

Change log entry:

None needed.

@codeofdusk codeofdusk changed the base branch from master to beta January 14, 2020 02:40
@AppVeyorBot
Copy link

See test results for failed build of commit 54af3039b9

@AppVeyorBot
Copy link

See test results for failed build of commit 664f1014ad

@AppVeyorBot
Copy link

See test results for failed build of commit 31d53948c5

@AppVeyorBot
Copy link

See test results for failed build of commit cfbf2d636c

@AppVeyorBot
Copy link

See test results for failed build of commit eed2b734c3

…cy, as fixing this seems out of scope for this PR).
@codeofdusk
Copy link
Contributor Author

Cc @LeonarddeR @michaelDCurran

@AppVeyorBot
Copy link

See test results for failed build of commit 2eaecfc37c

@michaelDCurran
Copy link
Member

the 'and's need to be on the start of the next line to stop the linting issues I think.

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@LeonarddeR
Copy link
Collaborator

I think this was already done using the https://github.com/nvaccess/nvda/tree/legacyWinConsoleByDefault branch

@AppVeyorBot
Copy link

@codeofdusk
Copy link
Contributor Author

I think this was already done using the https://github.com/nvaccess/nvda/tree/legacyWinConsoleByDefault branch

No, not quite. This PR reverts some additional UI, user guide, and behavior changes that were needed when UIA was the default.

@codeofdusk
Copy link
Contributor Author

I think this was already done using the https://github.com/nvaccess/nvda/tree/legacyWinConsoleByDefault branch

No, not quite. This PR reverts some additional UI, user guide, and behavior changes that were needed when UIA was the default.

It also keeps "auto" as the default config spec setting, allowing users to freely enable/disable UIA console during development and be automatically switched when it becomes the default.

@AppVeyorBot
Copy link

See test results for failed build of commit 5942d1788e

@michaelDCurran michaelDCurran merged commit 82eeff0 into nvaccess:beta Jan 14, 2020
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Jan 14, 2020
codeofdusk added a commit to codeofdusk/nvda that referenced this pull request Jan 23, 2020
codeofdusk added a commit to codeofdusk/nvda that referenced this pull request Apr 8, 2020
This reverts commit 82eeff0.
codeofdusk added a commit to codeofdusk/nvda that referenced this pull request Apr 8, 2020
codeofdusk added a commit to codeofdusk/nvda that referenced this pull request May 4, 2020
codeofdusk added a commit to codeofdusk/nvda that referenced this pull request Aug 7, 2020
@codeofdusk codeofdusk deleted the revert-cmduia-20193 branch October 26, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants