-
-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Automation in Windows Console: revert for 2019.3 #10684
UI Automation in Windows Console: revert for 2019.3 #10684
Conversation
See test results for failed build of commit 54af3039b9 |
2e500a8
to
3196ed4
Compare
See test results for failed build of commit 664f1014ad |
See test results for failed build of commit 31d53948c5 |
See test results for failed build of commit cfbf2d636c |
See test results for failed build of commit eed2b734c3 |
…cy, as fixing this seems out of scope for this PR).
See test results for failed build of commit 2eaecfc37c |
the 'and's need to be on the start of the next line to stop the linting issues I think. |
I think this was already done using the https://github.com/nvaccess/nvda/tree/legacyWinConsoleByDefault branch |
No, not quite. This PR reverts some additional UI, user guide, and behavior changes that were needed when UIA was the default. |
It also keeps "auto" as the default config spec setting, allowing users to freely enable/disable UIA console during development and be automatically switched when it becomes the default. |
See test results for failed build of commit 5942d1788e |
This reverts commit 82eeff0.
Link to issue number:
Completes #10682.
Summary of the issue:
It was decided to revert to legacy console support for 2019.3, but various UI and user guide elements remain from #9771.
Description of how this pull request fixes the issue:
auto
config setting is reverted to 2019.2 behavior (i.e. it maps to legacy).Testing performed:
Tested an upgrade from NVDA 2019.2.1 (stable) to this PR. Insured that legacy console is used by default and the UIA checkboxes are functional.
Known issues with pull request:
None.
Change log entry:
None needed.